#13192: some code clean up for sage/graphs/graph.py
----------------------------------+-----------------------------------------
Reporter: eisermbi | Owner: jason, ncohen, rlm
Type: defect | Status: positive_review
Priority: major | Milestone: sage-5.2
Component: graph theory | Resolution:
Keywords: sparse6_string | Work issues:
Report Upstream: N/A | Reviewers: Nathann Cohen, Karl-Dieter
Crisman
Authors: Birk Eisermann | Merged in:
Dependencies: #13109 | Stopgaps:
----------------------------------+-----------------------------------------
Changes (by kcrisman):
* status: needs_review => positive_review
Old description:
> The function compare_edges() of module 'sage.graphs.graph.py' is a simple
> comparison function used only in function sparse6_string(), and it works
> only on graphs whose vertices can be compared with the < operator, e.g.
> integers. Furthermore, the documentation is incomplete.
>
> Suggesting to replace it by a built-in function at the place where it was
> used.
New description:
The function compare_edges() of module 'sage.graphs.graph.py' is a simple
comparison function used only in function sparse6_string(), and it works
only on graphs whose vertices can be compared with the < operator, e.g.
integers. Furthermore, the documentation is incomplete.
Suggesting to replace it by a built-in function at the place where it was
used.
Apply [attachment:trac_13192-cleanup-v2.patch] and
[attachment:trac_13192_whitespace.patch].
--
Comment:
Just change the status if you have a problem with this, or if the patchbot
complains. I qrefreshed the patch to v2. Presumably the whitespace still
applies.
Patchbot, apply [attachment:trac_13192-cleanup-v2.patch] and
[attachment:trac_13192_whitespace.patch].
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/13192#comment:18>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
