#12380: Move methods from Word_nfactor_enumerable to FiniteWord_class
-----------------------------------+----------------------------------------
Reporter: slabbe | Owner: slabbe
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-5.3
Component: combinatorics | Resolution:
Keywords: | Work issues:
Report Upstream: N/A | Reviewers: André Apitzsch
Authors: Sébastien Labbé | Merged in:
Dependencies: #9958, #13073 | Stopgaps:
-----------------------------------+----------------------------------------
Changes (by slabbe):
* dependencies: #9958 => #9958, #13073
Comment:
Ticket #13073 just changed one line in the file
{{{sage/combinat/words/nfactor_enumerable_word.py}}}, so the patch here
does not apply anymore. I just updated the patch (under another name) with
the following affected changes :
{{{
#!diff
$ diff 12380_move_nfactors_methods-sl.patch 12380_move_nfactors_methods-
sl-updated.patch
426c426
< + from sage.graphs.all import DiGraph
---
> + from sage.graphs.digraph import DiGraph
1181c1181
< - from sage.graphs.all import DiGraph
---
> - from sage.graphs.digraph import DiGraph
}}}
The reviewer's patch still applies over the new updated one. I agree with
the changes made by the reviewer. All tests pass in
{{{sage/combinat/words}}}. Documentation builds fine. I give a positive
review to the reviewer's patch.
Because of changes made for #13073, I will not change the status of the
ticket to positive review. I give André a last look at it.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12380#comment:4>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
