#12380: Move methods from Word_nfactor_enumerable to FiniteWord_class
-----------------------------------+----------------------------------------
Reporter: slabbe | Owner: slabbe
Type: enhancement | Status: positive_review
Priority: major | Milestone: sage-5.3
Component: combinatorics | Resolution:
Keywords: | Work issues:
Report Upstream: N/A | Reviewers: André Apitzsch
Authors: Sébastien Labbé | Merged in:
Dependencies: #9958, #13073 | Stopgaps:
-----------------------------------+----------------------------------------
Description changed by jdemeyer:
Old description:
> The file {{{sage/combinat/words/nfactor_enumerable_word.py}}} and its
> class {{{Word_nfactor_enumerable}}} were introduced by ticket #8604. Just
> when it got merged into Sage, I realized it was a mistake. This class
> should not exist. The fact that its name was ugly was an indice. All
> those methods should be in a Language class (see #12225). It would get
> things a lot cleaner.
>
> Only the class {{{FiniteWord_class}}} was inheriting from it, so it farly
> easy to fix : just move the 14 methods from one class to the other.
>
> Note : this change will be unnoticed by the user.
>
> '''Apply''': 12380_move_nfactors_methods-sl-updated.patch
> trac_12380_reviewer.patch
New description:
The file {{{sage/combinat/words/nfactor_enumerable_word.py}}} and its
class {{{Word_nfactor_enumerable}}} were introduced by ticket #8604. Just
when it got merged into Sage, I realized it was a mistake. This class
should not exist. The fact that its name was ugly was an indice. All those
methods should be in a Language class (see #12225). It would get things a
lot cleaner.
Only the class {{{FiniteWord_class}}} was inheriting from it, so it farly
easy to fix : just move the 14 methods from one class to the other.
Note : this change will be unnoticed by the user.
'''Apply''': [attachment:12380_move_nfactors_methods-sl-updated.patch] and
[attachment:trac_12380_reviewer.patch]
--
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12380#comment:8>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
