#12339: Free Groups
--------------------------------+-------------------------------------------
Reporter: mmarco | Owner: joyner
Type: enhancement | Status: needs_review
Priority: minor | Milestone:
Component: group theory | Resolution:
Keywords: free groups | Work issues:
Report Upstream: N/A | Reviewers:
Authors: Miguel Marco | Merged in:
Dependencies: | Stopgaps:
--------------------------------+-------------------------------------------
Comment (by jhpalmieri):
I would suggest replacing `size` with `cardinality`. That's more in line
with other Sage modules. I would also suggest having a method which
returns the codomain of `G.simplification_isomorphism()`; if I have
generators and relations, I would like to see if there is a nice
accessible simplification. Also, and this is probably related to one of my
comments above:
{{{
sage: G = FreeGroup('g')
sage: E = G.quotient((G.gen(0),))
sage: E.simplification_isomorphism()
}}}
doesn't work, complaining that `ValueError: variable name must be
nonempty`.
The .gap method seems to work okay, although I haven't tested it very
thoroughly. From looking at other files in sage/groups/, it looks like you
should instead implement both `G._gap_()` (to return the GAP object
corresponding to G) and `G._gap_init_()` (to return the string
representation of the corresponding GAP object). But I'm not sure about
this: maybe you only need one of these methods. Anyway, if you do it
right, then `gap(G)` will return the GAP version of G.
Overall, your code should be consistent with the other groups available in
Sage, both in terms of public methods (for example, using `cardinality`
instead of `size`) and private ones (`_gap_`, `_gap_init_`, etc.)
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12339#comment:26>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
