#9265: Remove `CombinatorialClass` from sage.combinat.tableau
---------------------------------+------------------------------------------
Reporter: jbandlow | Owner: sage-combinat
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-5.3
Component: combinatorics | Resolution:
Keywords: | Work issues:
Report Upstream: N/A | Reviewers:
Authors: Jason Bandlow | Merged in:
Dependencies: | Stopgaps:
---------------------------------+------------------------------------------
Comment (by andrew.mathas):
Hi Anne,
Sorry for the slow response. As you no doubt worked out I didn't push the
updated patch onto the queue. I was avoiding doing this as I thought that
moving the patch up in the queue, and rebasing to 5.3, would cause
conflicts further down the queue.
Any way, in adding in the changes that you suggested above I decided to
push the new version onto the queue. I have made all of the changes that
your requested. In changing the names of the classes to Tableaux_size etc
I went a little further and changed self.n to self.size and changed the
named arguments to the parent classes, although the old named arguments
are still accepted.
Also, when I was fixing up the documentation error in __getitem__ that you
found I remember that I wanted to rewrite __getitem__ so that it supports
slices. It turned out that each of the semistandard tableaux parent
classes had its own getitem, so I removed all of these and added a generic
getitem to SemistandardTableaux class so that slices are now supported. To
make sure that this worked I put all of the doctests from the old getitems
into the new generic getitem and added a few more. To make things wok I
also had to add an is_finite methods to these classes -- this probably
should be implemented in the (In)FiniteEnumeratedSet category, but it is
not.
The new patch is both on trac and on the queue.
Andrew
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9265#comment:21>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
