#9265: Remove `CombinatorialClass` from sage.combinat.tableau
---------------------------------+------------------------------------------
       Reporter:  jbandlow       |         Owner:  sage-combinat
           Type:  enhancement    |        Status:  needs_review 
       Priority:  major          |     Milestone:  sage-5.3     
      Component:  combinatorics  |    Resolution:               
       Keywords:                 |   Work issues:               
Report Upstream:  N/A            |     Reviewers:               
        Authors:  Jason Bandlow  |     Merged in:               
   Dependencies:                 |      Stopgaps:               
---------------------------------+------------------------------------------

Comment (by aschilling):

 Hi Andrew,

 Thank you for your work on this. I ran sage -testall and got the following
 doctest failure:

 {{{
 sage -t  devel/sage-sf/sage/structure/sage_object.pyx
 **********************************************************************
 File "/Applications/sage-5.3.beta0/devel/sage-
 sf/sage/structure/sage_object.pyx", line 1114:
     sage: sage.structure.sage_object.unpickle_all()  # (4s on sage.math,
 2011)
 Expected:
     doctest:... DeprecationWarning: This class is replaced by
 Matrix_modn_dense_float/Matrix_modn_dense_double.
     See http://trac.sagemath.org/4260 for details.
     Successfully unpickled ... objects.
     Failed to unpickle 0 objects.
 Got:
      * unpickle failure:
 
load('/Users/anne/.sage/temp/lolita_4.local/85064/dir_2/pickle_jar/_class__sage_combinat_crystals_affine_AffineCrystalFromClassicalAndPromotion_with_category_element_class__.sobj')
      * unpickle failure:
 
load('/Users/anne/.sage/temp/lolita_4.local/85064/dir_2/pickle_jar/_class__sage_combinat_crystals_tensor_product_CrystalOfTableaux_with_category_element_class__.sobj')
      * unpickle failure:
 
load('/Users/anne/.sage/temp/lolita_4.local/85064/dir_2/pickle_jar/_class__sage_combinat_crystals_tensor_product_TensorProductOfCrystalsWithGenerators_with_category__.sobj')
      * unpickle failure:
 
load('/Users/anne/.sage/temp/lolita_4.local/85064/dir_2/pickle_jar/_class__sage_combinat_skew_tableau_SemistandardSkewTableaux_n__.sobj')
      * unpickle failure:
 
load('/Users/anne/.sage/temp/lolita_4.local/85064/dir_2/pickle_jar/_class__sage_combinat_skew_tableau_SemistandardSkewTableaux_nmu__.sobj')
      * unpickle failure:
 
load('/Users/anne/.sage/temp/lolita_4.local/85064/dir_2/pickle_jar/_class__sage_combinat_skew_tableau_SemistandardSkewTableaux_p__.sobj')
      * unpickle failure:
 
load('/Users/anne/.sage/temp/lolita_4.local/85064/dir_2/pickle_jar/_class__sage_combinat_skew_tableau_SemistandardSkewTableaux_pmu__.sobj')
      * unpickle failure:
 
load('/Users/anne/.sage/temp/lolita_4.local/85064/dir_2/pickle_jar/_class__sage_combinat_skew_tableau_StandardSkewTableaux_n__.sobj')
      * unpickle failure:
 
load('/Users/anne/.sage/temp/lolita_4.local/85064/dir_2/pickle_jar/_class__sage_combinat_tableau_SemistandardTableaux_n__.sobj')
      * unpickle failure:
 
load('/Users/anne/.sage/temp/lolita_4.local/85064/dir_2/pickle_jar/_class__sage_combinat_tableau_SemistandardTableaux_nmu__.sobj')
      * unpickle failure:
 
load('/Users/anne/.sage/temp/lolita_4.local/85064/dir_2/pickle_jar/_class__sage_combinat_tableau_SemistandardTableaux_p__.sobj')
      * unpickle failure:
 
load('/Users/anne/.sage/temp/lolita_4.local/85064/dir_2/pickle_jar/_class__sage_combinat_tableau_SemistandardTableaux_pmu__.sobj')
      * unpickle failure:
 
load('/Users/anne/.sage/temp/lolita_4.local/85064/dir_2/pickle_jar/_class__sage_combinat_tableau_StandardTableaux_n__.sobj')
      * unpickle failure:
 
load('/Users/anne/.sage/temp/lolita_4.local/85064/dir_2/pickle_jar/_class__sage_combinat_tableau_StandardTableaux_partition__.sobj')
      * unpickle failure:
 
load('/Users/anne/.sage/temp/lolita_4.local/85064/dir_2/pickle_jar/_class__sage_combinat_tableau_Tableau_class__.sobj')
      * unpickle failure:
 
load('/Users/anne/.sage/temp/lolita_4.local/85064/dir_2/pickle_jar/_class__sage_combinat_tableau_Tableaux_n__.sobj')
     doctest:1172: DeprecationWarning: This class is replaced by
 Matrix_modn_dense_float/Matrix_modn_dense_double.
     See http://trac.sagemath.org/4260 for details.
     Failed:
 
_class__sage_combinat_crystals_affine_AffineCrystalFromClassicalAndPromotion_with_category_element_class__.sobj
 
_class__sage_combinat_crystals_tensor_product_CrystalOfTableaux_with_category_element_class__.sobj
 
_class__sage_combinat_crystals_tensor_product_TensorProductOfCrystalsWithGenerators_with_category__.sobj
     _class__sage_combinat_skew_tableau_SemistandardSkewTableaux_n__.sobj
     _class__sage_combinat_skew_tableau_SemistandardSkewTableaux_nmu__.sobj
     _class__sage_combinat_skew_tableau_SemistandardSkewTableaux_p__.sobj
     _class__sage_combinat_skew_tableau_SemistandardSkewTableaux_pmu__.sobj
     _class__sage_combinat_skew_tableau_StandardSkewTableaux_n__.sobj
     _class__sage_combinat_tableau_SemistandardTableaux_n__.sobj
     _class__sage_combinat_tableau_SemistandardTableaux_nmu__.sobj
     _class__sage_combinat_tableau_SemistandardTableaux_p__.sobj
     _class__sage_combinat_tableau_SemistandardTableaux_pmu__.sobj
     _class__sage_combinat_tableau_StandardTableaux_n__.sobj
     _class__sage_combinat_tableau_StandardTableaux_partition__.sobj
     _class__sage_combinat_tableau_Tableau_class__.sobj
     _class__sage_combinat_tableau_Tableaux_n__.sobj
     Successfully unpickled 571 objects.
     Failed to unpickle 16 objects.
 **********************************************************************
 1 items had failures:
    1 of   7 in __main__.example_25
 ***Test Failed*** 1 failures.
 For whitespace errors, see the file
 /Users/anne/.sage/tmp/lolita_4.local-73054/sage_object_85063.py
          [14.0 s]
 }}}

 I suppose this is due to your renaming of the classes. Also, I am not
 sure, but you might have to put in deprecation warnings if certain parent
 classes suddenly disappear. The new deprecation syntax is available here
 http://trac.sagemath.org/sage_trac/ticket/13109.

 Best,

 Anne

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9265#comment:22>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to