#12215: Memleak in UniqueRepresentation, @cached_method
-------------------------------------------------------------------+--------
Reporter: vbraun |
Owner:
Type: defect |
Status: needs_work
Priority: major |
Milestone: sage-5.3
Component: memleak |
Resolution:
Keywords: UniqueRepresentation cached_method caching | Work
issues: Do not INCREF when deallocating
Report Upstream: N/A |
Reviewers:
Authors: Simon King | Merged
in:
Dependencies: #11115 #11900 #12645 #11599 #12808 #7980 #11521 |
Stopgaps:
-------------------------------------------------------------------+--------
Changes (by SimonKing):
* status: needs_review => needs_work
* work_issues: => Do not INCREF when deallocating
Comment:
Great! The scary INCREF apparently is not needed!! All tests in
sage/schemes and sage/sf pass. The following two examples previously
resulted in a segfault, but now they don't:
{{{
sage: half_integral_weight_modform_basis(DirichletGroup(16,QQ).1, 3, 10)
[]
sage: half_integral_weight_modform_basis(DirichletGroup(16,QQ).1, 5, 10)
[q - 2*q^3 - 2*q^5 + 4*q^7 - q^9 + O(q^10)]
sage: quit
Exiting Sage (CPU time 0m0.36s, Wall time 0m32.82s).
}}}
{{{
sage: half_integral_weight_modform_basis(DirichletGroup(16,QQ).1, 5, 10)
[q - 2*q^3 - 2*q^5 + 4*q^7 - q^9 + O(q^10)]
sage: half_integral_weight_modform_basis(DirichletGroup(16,QQ).1, 3, 10)
[]
sage: quit
Exiting Sage (CPU time 0m0.29s, Wall time 0m4.68s).
}}}
So, I will (a bit later today) update the segfault patch, fortunately
removing the odd INCREF.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12215#comment:106>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
