#12215: Memleak in UniqueRepresentation, @cached_method
--------------------------------------------------------------+-------------
Reporter: vbraun | Owner:
Type: defect | Status:
needs_review
Priority: major | Milestone:
sage-5.3
Component: memleak | Resolution:
Keywords: UniqueRepresentation cached_method caching | Work issues:
Report Upstream: N/A | Reviewers:
Authors: Simon King | Merged in:
Dependencies: #11115 #11900 #12645 #11599 #12808 #7980 | Stopgaps:
--------------------------------------------------------------+-------------
Comment (by SimonKing):
Hi Nils,
Replying to [comment:103 nbruin]:
> '''main patch:'''
>
> sage/categories/category.py
>
> You make some changes to _join, which has the note
>
> It is used for getting a temporary speed-up at trac ticket #11900.
> But it is supposed to be replaced by a better solution at trac
> ticket #11943.
>
> and #11943 was merged in 5.1! Is this function still used?
Thank you for spotting it. The plan was to replace it, but apparently it
wasn't done. So, I removed the note.
> '''sefault_fixes:'''
>
> sage/combinat/sf/sf.py
>
> There is still a change to that file, namely, you add
> "from sage.misc.cachefunc import cached_function"
>
> which is an odd thing to do in one patch by itself. Perhaps it's a
change you failed to revert?
I have removed the import. I also removed the ''strongly'' cached
classcall from sage/combinat/sf/sfa.py: it turns out that a strong cache
for symmetric function algebras is not needed any more, after the recent
overhaul.
> INCREF:
>
> scary stuff ...
I know. I am now testing whether it it still needed.
Anyway, it should now be ready for review. I think, to be on the safe
side, we should use #11521 as a dependency, which meanwhile has a positive
review (thank you!).
Apply trac12215_weak_cached_function-sk.patch
trac12215_segfault_fixes.patch
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12215#comment:104>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
