#12215: Memleak in UniqueRepresentation, @cached_method
--------------------------------------------------------------+-------------
Reporter: vbraun | Owner:
Type: defect | Status:
needs_review
Priority: major | Milestone:
sage-5.3
Component: memleak | Resolution:
Keywords: UniqueRepresentation cached_method caching | Work issues:
Report Upstream: N/A | Reviewers:
Authors: Simon King | Merged in:
Dependencies: #11115 #11900 #12645 #11599 #12808 #7980 | Stopgaps:
--------------------------------------------------------------+-------------
Comment (by nbruin):
Hi Simon,
I've read the patches to see if there is anything weird or questionable.
It looks good for the most part. Just some things you might be able to
comment on:
'''main patch:'''
sage/categories/category.py
You make some changes to _join, which has the note
It is used for getting a temporary speed-up at trac ticket #11900.
But it is supposed to be replaced by a better solution at trac
ticket #11943.
and #11943 was merged in 5.1! Is this function still used?
Otherwise: Looks good!
'''sefault_fixes:'''
sage/combinat/sf/sf.py
There is still a change to that file, namely, you add
"from sage.misc.cachefunc import cached_function"
which is an odd thing to do in one patch by itself. Perhaps it's a change
you failed to revert?
INCREF:
scary stuff ... I don't like black magic in code, but you seem to know
what
you're doing...
'''Conclusion:'''
I'd be close to giving a positive review. I haven't run test suits (yet),
but you've done a lot of that and the bot should be doing that anyway. The
changes themselves look fairly straightforward.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12215#comment:103>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
