#12943: Tableau_class.__div__,  Partition_class.__div__ are checking domination
when they should check inclusion
---------------------------------+------------------------------------------
       Reporter:  hthomas        |         Owner:  sage-combinat
           Type:  defect         |        Status:  needs_review 
       Priority:  minor          |     Milestone:  sage-5.3     
      Component:  combinatorics  |    Resolution:               
       Keywords:  tableau        |   Work issues:               
Report Upstream:  N/A            |     Reviewers:  Mike Hansen  
        Authors:  Hugh Thomas    |     Merged in:               
   Dependencies:                 |      Stopgaps:               
---------------------------------+------------------------------------------

Comment (by andrew.mathas):

 This looks good. The only change that I woiuld recommend is improving the
 grammar. Rather than
 {{{
 To form a skew partition p/q, it must be that q is contained in p
 }}}
 I suggest
 {{{
 To form the skew partition p/q, q must be contained in p
 }}}
 or even more simply:
 {{{
 the partition q must be contained in p
 }}}
 I am happy if you set whichever of the three variants that you think is
 best. Once you have decided what's best then, following Mike, please set
 this to a positive review.

 Andrew

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12943#comment:8>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to