#219: Segfault crash with input.jack()
-------------------------+--------------------------------------------------
  Reporter:  MiiJaySung  |       Owner:  toots     
      Type:  Bugs        |      Status:  assigned  
  Priority:  5           |   Milestone:  0.9.0     
 Component:  Liquidsoap  |     Version:  0.3.8+svn 
Resolution:              |    Keywords:  crash jack
       Mac:  1           |       Linux:  1         
    Netbsd:  1           |       Other:  1         
   Freebsd:  1           |  
-------------------------+--------------------------------------------------
Comment (by MiiJaySung):

 Just had a quick peak at the issue. I'm no C coder myself, but on the
 surface of it, looks like it's a basic C programming idiom / school boy
 error.

 Where you are making calls to:

   int n = strlen(...);

 You want to increment n by 1 ( i.e. int n = 1 + strlen(...); ) to
 accommodate the NULL string termination for the string name as strlen does
 not account for the termination. This explains why using ID's was causing
 issues. Might be an idea to grep through the rest of the code base though
 to make sure this doesn't affect the other sub projects.

 I'm guessing in 64 bit mode is using some different memory alignment
 policy (i.e. aligning to 32 or 64 bit boundaries rather bytes) which means
 the bug seems to not crop up (or only crop up at certain sizes).

-- 
Ticket URL: <http://savonet.rastageeks.org/ticket/219#comment:7>
Savonet <http://savonet.rastageeks.org/>
Let's program our stream !
------------------------------------------------------------------------------
_______________________________________________
Savonet-trac mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/savonet-trac

Reply via email to