#336: Review midi decoder
------------------------+---------------------------------------------------
 Reporter:  mrpingouin  |       Owner:  admin   
     Type:  Bugs        |      Status:  new     
 Priority:  1           |   Milestone:  1.0 beta
Component:  Liquidsoap  |     Version:          
 Keywords:              |         Mac:  1       
    Linux:  1           |      Netbsd:  1       
    Other:  1           |     Freebsd:  1       
------------------------+---------------------------------------------------

Comment(by mrpingouin):

 I have just committed the fixes as described above.

 First, the decoder needs to make sure MIDI channels are created. This is
 often unnecessary, e.g., in output(single(midi)) the output will provide a
 frame that has the expected number of channels, but in more complex
 settings this is not the case, e.g., output(drop_midi(single(midi))) the
 decoder is in charge of creating the channels.

 Second, since we do not produce blank audio and video, I made sure that
 the type allowed this. I don't think we need this. Otherwise, we can
 remove the restriction, provided that we also properly create/initialize
 those channels.

-- 
Ticket URL: <http://savonet.rastageeks.org/ticket/336#comment:3>
Savonet <http://savonet.rastageeks.org/>
Let's program our stream !
------------------------------------------------------------------------------
This SF.net email is sponsored by 

Make an app they can't live without
Enter the BlackBerry Developer Challenge
http://p.sf.net/sfu/RIM-dev2dev 
_______________________________________________
Savonet-trac mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/savonet-trac

Reply via email to