Cristian Stoica wrote:
> You could argue the reverse if the patch was already there and then 
> removed

Exactly, but the current code is in use by more than 4 years and there 
are no bug reports.
I'm not saying that adding "split" is wrong; the point is that it makes 
the code more robust, but it also changes the parsing logic.
Sure, we could simply commit the code and let users find if it add any 
bugs, but i think it's not the right way.
It's better to check if the fics protocol provide any guarantee against 
multiple spaces, think about possible corner cases, try to find better 
solutions for parsing, etc... (it's a lot of tedious work -> i'm not 
doing it :-)  -> but need to be done before committing the change).
Bye,
Fulvio

------------------------------------------------------------------------------
See everything from the browser to the database with AppDynamics
Get end-to-end visibility with application monitoring from AppDynamics
Isolate bottlenecks and diagnose root cause in seconds.
Start your free trial of AppDynamics Pro today!
http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk
_______________________________________________
Scid-users mailing list
Scid-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/scid-users

Reply via email to