Cristian Stoica wrote: > Sure, we could simply commit the code and let users find if it add any > bugs, but i think it's not the right way. > I'm against taking patches without review and testing. I fall into > this trap myself times and times again. I needed to know if the > example was to make a point (it does) or if you extracted it from a > real regression (I guess not but I don't know fics protocol enough to > make a call). Yes, i didn't try the patch, i just wanted to point out that need more testing
> > Speaking of it, what about four space tab-stops for new and updated > code (of course not for the sake of it)? In the eternal conflict between tabs vs spaces i'm a tabs supporter too. However in scid we try to maintain file consistency: when patching a file that used spaces you should use spaces, when patching a file that used tabs you should use tabs. If you code a new feature that deserve his own file you are free to choose (even if i hope that everyone see the light and stop using spaces :-) Bye, Fulvio ------------------------------------------------------------------------------ See everything from the browser to the database with AppDynamics Get end-to-end visibility with application monitoring from AppDynamics Isolate bottlenecks and diagnose root cause in seconds. Start your free trial of AppDynamics Pro today! http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk _______________________________________________ Scid-users mailing list Scid-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/scid-users
