>...but the current code is in use by more than 4 years and there are no
bug reports.
No bug reports doesn't mean there are no bugs. For example, I have three of
them in my queue (two for fics) that I did not report.
Sure, we could simply commit the code and let users find if it add any
> bugs, but i think it's not the right way.
>
I'm against taking patches without review and testing. I fall into this
trap myself times and times again. I needed to know if the example was to
make a point (it does) or if you extracted it from a real regression (I
guess not but I don't know fics protocol enough to make a call).
It's better to check if the fics protocol provide any guarantee against
> multiple spaces, think about possible corner cases, try to find better
> solutions for parsing, etc... (it's a lot of tedious work -> i'm not doing
> it :-)
Reducing entropy is always going to take energy. I am willing to put some
in. And I guess we all like some areas better than others. Speaking of it,
what about four space tab-stops for new and updated code (of course not for
the sake of it)?
Cristian S.
------------------------------------------------------------------------------
See everything from the browser to the database with AppDynamics
Get end-to-end visibility with application monitoring from AppDynamics
Isolate bottlenecks and diagnose root cause in seconds.
Start your free trial of AppDynamics Pro today!
http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk
_______________________________________________
Scid-users mailing list
Scid-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/scid-users
