Hi Chih-Jen Lin (as well as the scikit-learn mailing list) I've pushed a small change to libsvm today to sklearn (https://github.com/scikit-learn/scikit-learn/pull/1184) where a copy of the libsvm source is mirrored in sklearn's git project. We were wondering how to proceed. We do not want to diverge further than necessary from the official libsvm trunk, but this seems to be just one among a few features that sklearn developers have implemented. Divergence seems like something to manage rather than to avoid.
Do you have a github account? If not, would you mind it if we set up (on your behalf, if you would prefer not to be on github yourself) a "libsvm" project on github that simply tracks your official version? This would have two advantages: 1. the changes made for sklearn could be maintained as a separate branch, and quickly rebased to your new releases and 2. You can easily cherry-pick the changes you would like to include in the master branch (the normal github niceness) This "libsvm" project could be transferred to your account if you decide to set one up later. Your perspective on the matter would be much appreciated! Thanks, - James Bergstra On Wed, Sep 26, 2012 at 5:30 PM, Gael Varoquaux <[email protected]> wrote: > Hey Joseph, > > Fair enough with regards to your points about a fork being considered as > aggressive. Thanks a lot raising this point. I guess that I was more > thinking of fork in terms of version control rather than in terms of > creating a parallel project. I have grown used to fork being useful > things :). > > Also, I am worried that a collection of patches will bitrot, and my > immediate thought is to put them in a git, just to make sure that history > is conserved. > > Of course, my thoughts reflect very much that I am used to working with > open version-control project and distributed version control, which is > not the case here. > > Anyhow, both situations, the collection of patches and the fork, are > suboptimal situations. > > Thanks for your thoughts, > > Gaël > > On Wed, Sep 26, 2012 at 02:14:27PM -0700, Joseph Turian wrote: >> >> If sklearn will be maintaining a patch set against libsvm, this patch set >> >> should be available to non sklearn users too. > >> > I reckon you are volonteering to maintain a fork of libsvm? That's very >> > good news, the community definitely needs this badly. > >> I was considering the idea of a fork, but I think it might be premature. > >> Everyone seems to agree that it would be great if the patches merged >> upstream. > >> If the maintainers have been unwilling to merge patches, then they >> might not merge the patches this time around. > >> If you fork the project, that might be taken as an aggressive move and >> they will be unwilling to work together with the maintainers of the >> fork. > >> My thought was that releasing a patch set, but not actively >> maintaining it, and following it up with an email to maintainers: >> "We'd like to see our patch set merged into libsvm core code", then >> there is some pressure on libsvm to merge the patches but not an >> aggressive amount (like forking). > >> Just my thoughts. > >> Joseph > >> ------------------------------------------------------------------------------ >> How fast is your code? >> 3 out of 4 devs don\\\'t know how their code performs in production. >> Find out how slow your code is with AppDynamics Lite. >> http://ad.doubleclick.net/clk;262219672;13503038;z? >> http://info.appdynamics.com/FreeJavaPerformanceDownload.html >> _______________________________________________ >> Scikit-learn-general mailing list >> [email protected] >> https://lists.sourceforge.net/lists/listinfo/scikit-learn-general > > -- > Gael Varoquaux > Researcher, INRIA Parietal > Laboratoire de Neuro-Imagerie Assistee par Ordinateur > NeuroSpin/CEA Saclay , Bat 145, 91191 Gif-sur-Yvette France > Phone: ++ 33-1-69-08-79-68 > http://gael-varoquaux.info http://twitter.com/GaelVaroquaux > > ------------------------------------------------------------------------------ > How fast is your code? > 3 out of 4 devs don\\\'t know how their code performs in production. > Find out how slow your code is with AppDynamics Lite. > http://ad.doubleclick.net/clk;262219672;13503038;z? > http://info.appdynamics.com/FreeJavaPerformanceDownload.html > _______________________________________________ > Scikit-learn-general mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/scikit-learn-general ------------------------------------------------------------------------------ How fast is your code? 3 out of 4 devs don\\\'t know how their code performs in production. Find out how slow your code is with AppDynamics Lite. http://ad.doubleclick.net/clk;262219672;13503038;z? http://info.appdynamics.com/FreeJavaPerformanceDownload.html _______________________________________________ Scikit-learn-general mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/scikit-learn-general
