Although if we asked users to exclusively set parameters with set_params,
we could tack validation onto that, and hence in __init__ too.
On 19 February 2015 at 09:17, Andy <t3k...@gmail.com> wrote:
>
> On 02/17/2015 11:14 PM, Gael Varoquaux wrote:
> > I have been using set_params in my own interactive work, to modify
> > params on the fly. It wouldn't be the end of the world if the method
> > goes away, as long as we can still assign values to attributes. If we
> > can get rid of the overrides of set_params and get_params in our
> > codebase, I am not opposed to the plan
> Yeah, I think we want to support assigning values. But making the API
> slimmer seems desirable. It is not that hard to get right, but
> less requirements are nicer, I think.
> >> we could use __init__ to set the parameters directly, which would allow
> >> us to do input validation in __init__.
> > The logic for not putting input validation in __init__ is that it is
> > legit to do:
> >
> > clf = Blah(param1=1)
> > clf.param1 = 2
> > clf.fit(...)
> True, that is pretty useful to do and we want to support it.
>
>
>
> ------------------------------------------------------------------------------
> Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server
> from Actuate! Instantly Supercharge Your Business Reports and Dashboards
> with Interactivity, Sharing, Native Excel Exports, App Integration & more
> Get technology previously reserved for billion-dollar corporations, FREE
>
> http://pubads.g.doubleclick.net/gampad/clk?id=190641631&iu=/4140/ostg.clktrk
> _______________________________________________
> Scikit-learn-general mailing list
> Scikit-learn-general@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/scikit-learn-general
>
------------------------------------------------------------------------------
Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server
from Actuate! Instantly Supercharge Your Business Reports and Dashboards
with Interactivity, Sharing, Native Excel Exports, App Integration & more
Get technology previously reserved for billion-dollar corporations, FREE
http://pubads.g.doubleclick.net/gampad/clk?id=190641631&iu=/4140/ostg.clktrk
_______________________________________________
Scikit-learn-general mailing list
Scikit-learn-general@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/scikit-learn-general
