On 02/19/2015 12:58 PM, Gael Varoquaux wrote: > On Wed, Feb 18, 2015 at 02:17:55PM -0800, Andy wrote: >> Yeah, I think we want to support assigning values. But making the API >> slimmer seems desirable. It is not that hard to get right, but >> less requirements are nicer, I think. > Honestly, removing get_params, set_params from our required API would be > great. I am all with you. > > The question is: can we do this without breaking our pipeline delegation > mechanism that we use to set parameters during cross-validation in a > pipeline? I am not convinced that this is possible. Maybe a complex > mechanism overridding __getattr__, or in other ways the attribute lookup > in python, would do it, but that would be greater evil. All this logic is in set_params, which is not overwritten in pipeline. Making this a function, instead of a method in BaseEstimator should not require any change at all, if I am not very blind.
------------------------------------------------------------------------------ Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server from Actuate! Instantly Supercharge Your Business Reports and Dashboards with Interactivity, Sharing, Native Excel Exports, App Integration & more Get technology previously reserved for billion-dollar corporations, FREE http://pubads.g.doubleclick.net/gampad/clk?id=190641631&iu=/4140/ostg.clktrk _______________________________________________ Scikit-learn-general mailing list Scikit-learn-general@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/scikit-learn-general
