Right, I guess that place is the crux.
Somehow I was looking only at set_params, not get_params.
A simple way to overcome the issue would be to declare sub-estimators in
an attribute.
While maybe not very elegant, that would allow us to implement the
function in a single place.
Btw, I just realized that RFE and BaggingEstimator don't overload
get_params or set_params.
So grid-searches there look a bit different. I am wondering whether we
should also introduce the __ notation here.
On 02/19/2015 09:47 PM, Joel Nothman wrote:
It only works because Pipeline overloads get_params.
On 20 February 2015 at 09:17, Andy <t3k...@gmail.com
<mailto:t3k...@gmail.com>> wrote:
On 02/19/2015 12:58 PM, Gael Varoquaux wrote:
> The question is: can we do this without breaking our pipeline delegation
> mechanism that we use to set parameters during cross-validation in a
> pipeline? I am not convinced that this is possible. Maybe a complex
> mechanism overridding __getattr__, or in other ways the
attribute lookup
> in python, would do it, but that would be greater evil.
All this is implemented in BaseEstimator.set_params, which is not
overloaded in pipeline.
Making it a function instead of a method should be as easy as
replacing
est.set_params(**params)
by
set_params(est, **params)
Unless I'm pretty blind (which is possible)
------------------------------------------------------------------------------
Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server
from Actuate! Instantly Supercharge Your Business Reports and
Dashboards
with Interactivity, Sharing, Native Excel Exports, App Integration
& more
Get technology previously reserved for billion-dollar
corporations, FREE
http://pubads.g.doubleclick.net/gampad/clk?id=190641631&iu=/4140/ostg.clktrk
_______________________________________________
Scikit-learn-general mailing list
Scikit-learn-general@lists.sourceforge.net
<mailto:Scikit-learn-general@lists.sourceforge.net>
https://lists.sourceforge.net/lists/listinfo/scikit-learn-general
------------------------------------------------------------------------------
Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server
from Actuate! Instantly Supercharge Your Business Reports and Dashboards
with Interactivity, Sharing, Native Excel Exports, App Integration & more
Get technology previously reserved for billion-dollar corporations, FREE
http://pubads.g.doubleclick.net/gampad/clk?id=190641631&iu=/4140/ostg.clktrk
_______________________________________________
Scikit-learn-general mailing list
Scikit-learn-general@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/scikit-learn-general
------------------------------------------------------------------------------
Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server
from Actuate! Instantly Supercharge Your Business Reports and Dashboards
with Interactivity, Sharing, Native Excel Exports, App Integration & more
Get technology previously reserved for billion-dollar corporations, FREE
http://pubads.g.doubleclick.net/gampad/clk?id=190641631&iu=/4140/ostg.clktrk
_______________________________________________
Scikit-learn-general mailing list
Scikit-learn-general@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/scikit-learn-general
