Bruce Dodson wrote:
Okay, in that case it would be a common method that is called by both AddJob
and ToolsMenu, rather than having ToolsMenu call AddJob directly. (Mainly
for the sake of clenliness.)
I have removed DecodeCommandMode() from Extender.h, and altered
LuaExtension.cxx accordingly.
There is some name confusion though. SciTE is a sample application, not a
library. With that in mind, would it be okay to reconcile some of these
names? Right now we have AddCommand, AddJob, and Execute (plus whatever we
call the worker method that gets invoked from both ToolsMenu and AddJob).
It gets difficult to keep track.
I was attempting to rename the JobQueue stuff to CommandQueue when I ran
into a self-made bug with
command = SString(command.command);
The multiple uses of 'command' confused the compiler. I know I can use
this->command = SString(command.command);
but I wanted to hold off until we get some consensus on the use of the
names.
- the menu is called 'Tools'
- the properties are 'command....'
- the internal enum values for subsystem and flags are job...; this must
be where I got JobQueue from
I have uploaded to
http://www.scintilla.org/aprilw/scite-april-2006-02-05.zip my revisions
to date. I will be away on business for the week, in the mean time
please discuss amongst yourselves whether the JobQueue system should be
renamed to CommandQueue.
As well, the suggestion offered by Bruce whereby the ToolMenu() method
builds one large command mode string to be passed into
DecodeCommandMode(), are there any objections to it? I have looked at
it and see some merit to it, though I would probably define and loop
through an array of command properties and equivalent mode strings, to
consolidate this new implementation. Right now there are a half dozen
repeated blocks of code that could be reduced.
BTW Bruce, I am not quite sure which "Execute" you are referring to.
Since Lua already has an Execute() method I thought it would be more
natural for script writers to use scite.Execute(). Within SciTE itself
I removed SciTEWin::Execute().
ttfn
April
--
A man's got to do what a man's got to do. A woman must do what he can't.
Rhonda Hansome
_______________________________________________
Scite-interest mailing list
[email protected]
http://mailman.lyra.org/mailman/listinfo/scite-interest
