From: "Bruce Dodson" <[EMAIL PROTECTED]>
If there is a function to decode the command mode string (that doesn't add
to the job queue), it needs more parameters. In particular, the
"save-before" value should not be stuffed into the flags. Save-before is
not a queued action: the save occurs in the main thread, before the command
is added to the queue, and the flag isn't needed later. So, it is cleaner
to keep it separate from the flags.
The save-before-prompt flag is excluded from extenders, to avoid threading
problems. I think I added all of these flags to more easily pass values
between the new method and the caller. Look inside LuaExtension at the
..._execute method, it to saves the buffer. I have not seen any messages
from Neil as to this code, but that does not mean it is wanted. More
discussion is needed I think.
I had one more observation about that function (DecodeCommandMode): The
parameters are pointers, not references. Was that an arbitrary choice, or
were there technical / design reasons for it? I don't mind if they are
pointers; but if they are pointers, perhaps the function should check for
null and ignore the corresponding command.mode flags if the pointer is
null.
The params are pointers because the original method was to be used by
extenders. An oversight, they can be byref. I will amend next weekend.
April
_______________________________________________
Scite-interest mailing list
[email protected]
http://mailman.lyra.org/mailman/listinfo/scite-interest
