Mark J. Nelson writes: > > http://cr.opensolaris.org/~mjnelson/webrev.tools_cleanup_wad/ > > http://anthrax.central/net/mrliberal.central/export/ws/mjnelson/onnv-bugfixes/webrev.onswan/
usr/src/tools/Makefile.tools 48,69,75-77: these seem to be duplicates. Mismerge? usr/src/tools/SUNWmrtools/prototype_com 47-53: what is this? usr/src/tools/env/developer.sh 59: the readmes for the gate also need to be updated. usr/src/tools/lintdump/Makefile 33-34: already the default in Makefile.master; shouldn't be needed. 35: this should already be the default. usr/src/tools/protolist/protolist.c 59: as long as you're picking typing nits, why would we be throwing away things that are relevant? (Did the original author mean "irrelevant?") usr/src/tools/scripts/nightly.sh 2219,2366: it looks to me like you might need a $TMPDIR/new_closed flag as well. If someone is switching from closed binaries to closed source, then the usr/closed directory could be pulled over in its entirety, and the per-changeset output would be huge. -- James Carlson, Solaris Networking <james.d.carlson at sun.com> Sun Microsystems / 35 Network Drive 71.232W Vox +1 781 442 2084 MS UBUR02-212 / Burlington MA 01803-2757 42.496N Fax +1 781 442 1677
