David and Rainer: I embedded questions to each of you below.
James Carlson wrote: > Mark J. Nelson writes: >>> http://cr.opensolaris.org/~mjnelson/webrev.tools_cleanup_wad/ >>> http://anthrax.central/net/mrliberal.central/export/ws/mjnelson/onnv-bugfixes/webrev.onswan/ > > usr/src/tools/Makefile.tools > > 48,69,75-77: these seem to be duplicates. Mismerge? Yes, apparently. I cleaned it up. This was my fault, not Rainer's. He sent the original patches for this a long, long time ago, before I had integrated the hgstyle changes. I didn't catch that part of this was now redundant. > usr/src/tools/SUNWmrtools/prototype_com > > 47-53: what is this? A vestigial tail. The SUNWmrtools package was used for sideband delivery to RE, when we changed things they needed for cdkit. I think. I asked about removing it, and got mild pushback (I think from Jan, Jerry, or both), on the supposition that leaving the skeleton in place as a template might make it easier to deliver such a thing on short notice, should it ever become necessary. The two changes here (removal of prototype_sparc and commenting out files in SUNWmrtools) were made to silence the protocmp output. The package should never have had a prototype_sparc with ARCH=i386.i86pc, and the binaries in question are legitimately not part of the tools proto area anyway. So I removed the former and commented out the latter. I don't really care for it much; I think that "hg rm usr/src/tools/SUNWmrtools" is probably more appropriate. But this leaves us with a skeleton svr4 pkg, and a clean tools protocmp. > usr/src/tools/env/developer.sh > > 59: the readmes for the gate also need to be updated. Thank you. Dave Marker: what's your feeling on pushing this usage? You were kind of keen on letting it remain available but unadvertised for a while. > usr/src/tools/lintdump/Makefile > > 33-34: already the default in Makefile.master; shouldn't be needed. I had imagined that any changes made here were done to silence protocmp, but I'll ask Rainer. > 35: this should already be the default. Yes, but Makefile.tools overrides this to be 0555. > usr/src/tools/protolist/protolist.c > > 59: as long as you're picking typing nits, why would we be throwing > away things that are relevant? (Did the original author mean > "irrelevant?") I'm not picky on this; I interpreted the comment as meaning that "including '.' in the protolist would cause problems," ie "be relevant." > usr/src/tools/scripts/nightly.sh > > 2219,2366: it looks to me like you might need a $TMPDIR/new_closed > flag as well. If someone is switching from closed binaries to > closed source, then the usr/closed directory could be pulled over in > its entirety, and the per-changeset output would be huge. Ok, I had mostly thought of that as a corner case, but it doesn't sound like an unreasonable thing to do. --Mark
