On Thu, May 08, 2008 at 04:59:11PM -0600, Mark J. Nelson wrote:
> > Mark has taken a brief look, and was at least fairly happy with the
> > changes (slightly happier than I was, anyway).
>
> In particular, I'm hoping that Dean will chime in on whether or not he's
> OK with this approach, and that "somebody that isn't me" will look at it
> from the point of view of a reasonably critical technical reviewer.
At first glance, I think I like it. Unfortunately, I still find certain
python concepts to be mind-boggling:
[t for t in fh if t.split(' ')[0] not in nodes]
That seems to do the opposite of what I would expect, but I'm sure that's not
true, so I guess it's not an intuitive construct...I'll spend some time using
the code today.
As an aside: can we please get webrev to use 'diff -p', or 'diff --git',
(or..you get the idea) by default? (How can you ON guys do code reviews when
you can't see which function the hunk belongs to? Adding -p is like turning
on the lights in a darkened room.)
Dean
