Dean Roehrich writes: > As an aside: can we please get webrev to use 'diff -p', or 'diff --git', > (or..you get the idea) by default? (How can you ON guys do code reviews when > you can't see which function the hunk belongs to? Adding -p is like turning > on the lights in a darkened room.)
The "-p" flag isn't available on diff. I suspect you're thinking of either "gdiff" or some other OS. In any event, I know that GNU diff -p is common for most open source reviews, but I can't say this issue has _ever_ bothered me with ON. I think if you know the code well enough to do a decent review of it or if you're at least looking at the source itself in another window, then the context and line numbers are sufficient. -- James Carlson, Solaris Networking <james.d.carlson at sun.com> Sun Microsystems / 35 Network Drive 71.232W Vox +1 781 442 2084 MS UBUR02-212 / Burlington MA 01803-2757 42.496N Fax +1 781 442 1677
