Could I get a review for: 356 cdm recommit needs to cope with the tags it may be trashing
http://cr.opensolaris.org/~richlowe/scm_356 This enhances the recommit code such that tags referring to a node in the active list are removed during the recommit, rather than left dangling pointing to a now non-existent node. This code used to request confirmation from the user before proceeding, but, on further thought, I can't imagine a valid reason to say no (and thus halt the recommit), in that instance, as such the code is removed. Also of note is that we don't do anything special to make sure the .hgtags change is committed. The logic here is thus, for .hgtags to contain a reference to a node in the active list, it itself must be present in the active list (to cause the tag to exist), and as such, will already be in active.files(). Perhaps this should be made more explicit? -- Rich
