I have a couple minor concerns, and I gather the logic for when to pull the closed tree is not quite right...?
First issue: you replaced "$SRC/../closed" with "$CODEMGR_WS/usr/closed", but not everywhere. Is there a particular reason for making that change? I'd like to see the rationale in the Bugster entry, so that people aren't left wondering in the future. Perhaps more important, I'd like to see a single idiom used throughout nightly.sh, so that people aren't scratching their heads over why $SRC/../closed is used in some places and $CODEMGR_WS/usr/closed is used in others. Maybe the references should all be changed to $CLOSEDSRC (or some other appropriately named and initialized variable)? Second issue: can you show an example of the mail message with the new merge warning/error messages? I'm wondering if it's possible to make the messages sufficiently visible without resorting to visual bells like "***". Such visual bells seem likely to accumulate over time, making the mail message increasingly noisy, leading to louder bells, and so on. mike
