"Mark J. Nelson" <Mark.J.Nelson at Sun.COM> writes: >> First issue: you replaced "$SRC/../closed" with >> "$CODEMGR_WS/usr/closed", but not everywhere. Is there a particular >> reason for making that change? I'd like to see the rationale in the >> Bugster entry, so that people aren't left wondering in the future. > > Style. The use of "$SRC/../closed" bothers me, so I fixed the ones > that glared at me while making these changes, but didn't do a global > seek/destroy. > > No effective difference, those changes are tangential to this fix. > >> Perhaps more important, I'd like to see a single idiom used throughout >> nightly.sh, so that people aren't scratching their heads over why >> $SRC/../closed is used in some places and $CODEMGR_WS/usr/closed is used >> in others. > > We already violate that, which doesn't mean it's OK, just that it > still doesn't tell us which should be preferred. > >> Maybe the references should all be changed to $CLOSEDSRC (or some other >> appropriately named and initialized variable)? > > Seems reasonable, though it would probably be CLOSEDROOT or somesuch.
That would suggest a relation to $ROOT, to me. The rest of the build uses $CLOSED, I'd go with that. -- Rich
