As we discussed on IRC, please remove the "-n" from the recommendation
to rerun nightly due to a merge failure.  (For the folks following by
email, if the merge of the open tree fails, the closed tree will not get
pulled.  So when the user reruns nightly, it needs to go through the
bringover path again.)

In bringover_mercurial, the code for the open and closed trees is
awfully similar.  It probably should be refactored into a single
function that is used twice, once for each tree.  I'm okay with it going
in as-is, but I'd like to see a cleanup bug filed after putback.

Other than that, looks good.  Thanks for iterating.

mike

Reply via email to