http://bugs.grommit.com/show_bug.cgi?id=268
------- Comment #4 from mike.kupfer at sun.com 2007-09-13 11:51 PDT ------- Here's what I came up with after looking through the i. files under usr/src/pkgdefs. I only looked at files that contained "@", "ident" (grep -w), or "pragma" (grep -w). I looked at two issues. First, what will the script do when SCCS keywords are not expanded. Second, what will the script do when someone removes the pragma/ident line from the source completely. I've double-checked my work some, but having someone else review this would be helpful. The scripts can be put in the following buckets, in order of increasing badness: I. script needs no change. common_files/i.hosts (only action is to remove extra ident line from merged ipnodes file) common_files/i.inetdconf (removes old ident line if going from pre-SMF to post-SMF) common_files/i.pcicconf (removes old ident line if it edits the user's file; no issue if ident line is deleted from source) common_files/i.policyconf (replaces initial comment block in user's file with initial comment block from new version of file) II. script needs no immediate change; will simply delete the ident line in the user's file. Should be cleaned up eventually, though. common_files/i.cronroot common_files/i.devallocdefs (only deletes the ident line if there is one present in the new version; does this whether or not keywords are expanded) common_files/i.devlinktab_i386 common_files/i.devlinktab_sparc common_files/i.dialers common_files/i.etcprofile common_files/i.kclasses_sparc common_files/i.locallogin common_files/i.localprofile common_files/i.powerconf common_files/i.rbac (only deletes the ident line if there is one present in the new version; does this whether or not keywords are expanded) common_files/i.sdconf_i386 common_files/i.syslogconf common_files/i.ttysrch III. script needs no immediate change; will replace the ident line with one containing unexpanded keywords. SUNWos86r/i.mach (will delete ident line when it's removed from source) common_files/i.ibnexconf (initially no-op, because action is tied to specific contents of file, not revision; will replace ident line with blank line when it's removed from source; subsequent runs will emit "?" error from ed(1)) common_files/i.kclasses_i386 (will delete ident line when it's removed from source) common_files/i.mptconf (will leave ident line in file when it's removed from source) common_files/i.scsivhciconf (will leave ident line in file when it's removed from source) IV. script needs no immediate change; may introduce one or more extra comment or blank lines when run. common_files/i.confupdate common_files/i.inittab (will only introduce extra lines after ident line is removed from source) common_files/i.mailxrc V. script should be changed prior to Mercurial transition. common_files/i.etcrpc (code will just delete the ident line, but it does compare SCCS revision strings. Someone might think it's a meaningful comparison and add broken code.) VI. script must be fixed prior to Mercurial transition: SUNWrmodr/i.master (unexpanded keywords will lead to syntax errors from expr; will stop trying to update user's version of file) common_files/i.etcsystem (has update logic tied to change in revision strings) VII. needs more research common_files/i.publickey (apparently trashes any non-comment lines; not our issue, but we might want to file a bug) -- Configure bugmail: http://bugs.grommit.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.