Richard Lowe wrote:
> Jason Zhao wrote:
>> Steve:
>>
>> Very glad to hear your comments.
>> Now I have changed the code of flg.flp and xref.I'd like to request
>> to review.
>>
>> After that,I hope to putback to scm gate.
>>
>
> Hi Jason,
>
> A few things, most of them nits.
>
> - Update/fix format of copyright
>
> - SCCS Keywords shouldn't be expanded (and possibly should be removed)
>
> - flg.flp.sh:76 Use 'workspace name' to test for TeamWare, not
> $CODEMGR_WS/Codemgr_wsdata (and adjust error message further down)
>
> - xref.sh:102 Same as above.
>
> - Wrap lines at 80 columns.
>
> -- Rich
My comments:
flg.flp:
CDDL text should be updated
76:same comment as Rich, though I think that you might need to bring
'workspace' into the path in 36. If 'workspace' can't be found, then it
seems reasonable to keep the current '-n $CODEMGR_WS && -d ...' check as
a fallback. If you update it, change the help text at 190 to reflect that.
the same applies for xref.sh
Otherwise it looks fine to me; I haven't done much testing of it yet though.
cheers,
steve
--
stephen lau // stevel at sun.com | 650.786.0845 | http://whacked.net
opensolaris // solaris kernel development
