Stephen Lau wrote:
> Thanks Jason. I'm not sure about defaulting to /ws/on10-tools if
> $BUILD_TOOLS isn't set. At the very least we should probably default it
> to onnv-tools since this will be going into onnv-gate.
Certainly it should be onnv-tools.
> That aside, I'd be fine with just including $BUILD_TOOLS in the path and
> doing a check for 'workspace' afterwards to see if it's present. If
> not, then throw a warning to denote that it can't use workspace to check
> for the presence of a Teamware repository, and proceed with the previous
> $CODEMGR_WS/Codemgr_wsdata check.
>
> Jason Zhao wrote:
>> Hi,Rich & Steve:
>>
>> Very thanks for you detailed review.Here is new scripts after make
>> some modifications.
>>>>
>>>> Hi Jason,
>>>>
>>>> A few things, most of them nits.
>>>>
>>>> - Update/fix format of copyright
>>>>
>>>> - SCCS Keywords shouldn't be expanded (and possibly should be removed)
>>>>
>>>> - flg.flp.sh:76 Use 'workspace name' to test for TeamWare, not
>>>> $CODEMGR_WS/Codemgr_wsdata (and adjust error message further down)
>>>>
>>>> - xref.sh:102 Same as above.
>>>>
>>>> - Wrap lines at 80 columns.
>>>>
>>>> -- Rich
>>>
>>> My comments:
>>> flg.flp:
>>> CDDL text should be updated
>>>
>>> 76:same comment as Rich, though I think that you might need to
>>> bring 'workspace' into the path in 36. If 'workspace' can't be
>>> found, then it seems reasonable to keep the current '-n $CODEMGR_WS
>>> && -d ...' check as a fallback. If you update it, change the help
>>> text at 190 to reflect that.
>>>
>> I made a change as following:
>>
>> 1.change Copyright to 2007
>> 2.remove SCCS keywords
>> 3.use "cstyle" make a check to ensure the line characters.
>> 4.change CDDL header
>> 5.add 'workspace name' as following order:
>> - first, check 'workspace name' exists ---> teamware
>> - second,check 'hg root' exists ---> mercurial
>> - if above both not exist,check $CODEMGR_WS and -d
>> $CODEMGR_WS/Codemgr_wsdata,if exists--->teamware
>> - none above,unknown.
>>
>> 6.help and path codes.
>> -
>> PATH=/usr/bin:/usr/ccs/bin:${BUILD_TOOLS:-/ws/on10-tools}/teamware/bin(flg.flp
>>
>> line 34)
>> - CODEMGR_WS=`workspace name` if teamware(flg.flp line 201)
>> - Help info
>> Unable to determine SCM type currently in use.
>> For teamware: /usr/local/sbin/flg.flp looks for either in
>> the environment or in the file list.
>> Run 'workspace name' to check if in workspace
>> <------------ added
>> For mercurial: /usr/local/sbin/flg.flp runs 'hg root'.
>>
>> I attach the new xref and flg.flp.
>>
>>
>> Thanks
>> Jason
>>
>
>
