Jason Zhao wrote: > Steve and Rich: > Stephen Lau wrote: >> Richard Lowe wrote: >>> Richard Lowe wrote: >>>> Stephen Lau wrote: >>>>> Thanks Jason. I'm not sure about defaulting to /ws/on10-tools if >>>>> $BUILD_TOOLS isn't set. At the very least we should probably >>>>> default it to onnv-tools since this will be going into onnv-gate. >>>> >>>> Certainly it should be onnv-tools. >>>> >>> >>> Actually, I take that back. When onnv moves to mercurial, it's not >>> beyond expectation that /ws/onnv-tools/teamware wouldn't exist, >>> whereas on10-tools/teamware certainly would, so this could go either >>> way. >>> >>> However, most other scripts appear to look for teamware in >>> /opt/teamware. >> >> I think /opt/teamware generally is dependent upon build machine >> maintainers putting it there; which makes me wonder if they will >> continue to do that once we switch to Mercurial. >> >> I don't foresee /ws/onnv-tools/teamware going away anytime soon. But >> given that Teamware hasn't changed much (at all?) between on10 and >> onnv, I guess I can live with on10-tools. >> >> Maybe it should check in order: /opt/teamware, /ws/onnv-tools, >> /ws/on10-tools. ? Or is that just too much overkill? >> > OK to check in the 3 above paths.I shall add the following code; > if [ -n "$BUILD_TOOLS" ]; then > PATH=/usr/bin:/usr/ccs/bin:${BUILD_TOOLS}/teamware/bin > else > > PATH=/usr/bin:/usr/ccs/bin:/opt/teamware/bin:/ws/onnv-tools/teamware/bin:/ws/on10-tools/teamware/bin > > > fi > export PATH > > But considered that users can put teamware any directories on his disk > as maintainers want.I would like to be OK only to look for teamware in > /opt/teamware.
Hi Jason, I just realised I never actually responded to this - your suggestion looks fine. Please go ahead and commit and push your changes to the project gate. cheers, steve -- stephen lau // stevel at sun.com | 650.786.0845 | http://whacked.net opensolaris // solaris kernel development