Richard Lowe wrote: > Stephen Lau <stevel at sun.com> writes: > >> http://cr.opensolaris.org/~stevel/292_wx-cdm/ >> >> code review please? >> this should support the bizarre cases of a Teamware workspace nested >> within a Mercurial workspace as well as a Hg workspace within a Teamware >> workspace correctly which are about the only weird edge cases i could >> think of. >> >> i'm open to putting a different URL there if people want. > > This is only going to work if the user has access to TeamWare (the > binaries), but is in the wrong gate. If they're on a build machine > without teamware, it's going to give them the "cannot find workspace > command in $PATH" error, as always. Is that what we want?
It carries forward the same behaviour as before. For that case, do we want to check to see if it's a Mercurial repository and throw the Mercurial error message, or maintain the same error message they would have gotten anyway? I'm fine either way. cheers, steve -- stephen lau // stevel at sun.com | 650.786.0845 | http://whacked.net opensolaris // solaris kernel development
