Hey all, Could I get review of:
#442 ws should stop talking about 5.0, check uname -s Webrev: http://cr.opensolaris.org/~richlowe/scm_442 This deals with two of sommerfeld's code review comments: WES-7 line 371: I think you mean "SunOS 5.x-specific" since 5.0 is long gone. WES-8 Lines 376-408: I suspect a "uname -s" check is also in order. The mentions of "5.0" and things being "5.x specific" are removed, and the condition surrounding the warning message reversed (and only surrounding the warning), since SunOS 5.x is really the only option. However, I left the message as a warning, rather than an error. I would be ok with making it fatal (and checking it sooner), but am not certain whether at least attempting to run in other places is something people do or may make use of. Opinion either way would be welcomed. Certain of the conditionals were ksh-ified on the way through, but should be equivalent. I'm happy to remove those changes, if asked, and would also be ok with dealing with the handful of other tests that do flagrantly bourne-ish things for no reason other than history. -- Rich
