Richard Lowe writes: > Webrev: > http://cr.opensolaris.org/~richlowe/scm_442
While you're there, do lines 376-377 do anything? Since when do we install onbld in /usr? I'd support simplifying a lot of this old logic. If you don't have $ONBLD_DIR, you can get it by doing 'whence' on $0 and stripping bin/ws from the end. That way, you'd cope with people who install SUNWonbld in strange places. And it'd sort of be nice to avoid prepending $ONBLD_DIR to the front of the path if it's already on the path (which it is for most users). It's wrong to do that at least because you're missing $ONBLD_DIR/$MACH. Anyone who has his own private "ws" and doesn't have it stored along with the build tools *and* doesn't have ONBLD_DIR set will be hurt, because the old code would have just "assumed" /opt/onbld/bin (without the architecture-specific directory!), but that sounds like a minor heads-up message to me. > Certain of the conditionals were ksh-ified on the way through, but > should be equivalent. I'm happy to remove those changes, if asked, > and would also be ok with dealing with the handful of other tests that > do flagrantly bourne-ish things for no reason other than history. I see no good reason to change them all, but if you felt strongly, it'd be ok by me. -- James Carlson, Solaris Networking <james.d.carlson at sun.com> Sun Microsystems / 35 Network Drive 71.232W Vox +1 781 442 2084 MS UBUR02-212 / Burlington MA 01803-2757 42.496N Fax +1 781 442 1677
