http://bugs.grommit.com/show_bug.cgi?id=473
------- Comment #5 from richlowe at richlowe.net 2008-04-26 20:29 PDT -------
>From what I can tell this has only ever worked with a known file list
(the wx active list, or specified. flist_from_teamware wants a real parent)
In the Hg case, with a specified file list (which contains parent
specification, file list, and comments), we get a harmless bit of error output.
If we lack any of the above, we'll error more fatally.
There's several things we can do here, none of them entirely correct:
- Use the workspace's natural parent (workspace parent, hg path default)
for the information we lack, but use the webrev for comparison
(if you've changed more files since the webrev, they'll show as new,
sadly).
- Use the file list from the old webrev, get comments from the natural parent
This will avoid the problem with newly changed files in the above, but also
not show them at all, which is equally bad.
We'd also still have to ask the natural parent for comments.
I'm not sure if we should stretch to make this work with teamware and no
pre-known file list, but I suspect we could in the same manner as above.
I'm not yet sure about subversion in this case.
--
Configure bugmail: http://bugs.grommit.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
