Hi Rob, thanks for the patches.
I will be sending you a private release (.zip file) you could retest.
I started going over them and trying to merge. You did A LOT OF HARD
WORK. Some comments I have:
(1) testdirector_config does not belong in daemon.conf. It belongs
somewhere on the filesystem where TestDirector is installed. I would
assume that TestDirector already provides some "other" configuration
file that describes all these settings. The backend should read them
from that file. It can use bugtracker->{ installation_directory } to
pick up the installation directory of TestDirector and append to it the
path to that configuration file.
NOTE: This is a much bigger problem in Scmbug in general. Both Mantis
and Bugzilla hardcode their configuration settings in their source code,
instead of some configuration file, or the database. As a result, Scmbug
currently hardcodes in the backend itself these values; if a user needs
to customize them, they must modify the backend. If they want this more
configurable, they must request these options to be more configurable to
the developers of the bugtracker.
So, for TestDirector, I removed those settings from the daemon, and
hardcoded them in the backend. If TestDirector has a more flexible way
of reading them, maybe parsing them from another file, then that's
great. But they don't belong in daemon.conf.
(2) If I'm understanding this correctly, TestDirectorUtils.pm exists
because of the OLE bug, right ? One thing that worries me is that it
does not contain version information. So when TestDirector 10.0 comes
out and the interface changes you won't be able to say:
if (is_version_latest()) {
} else {
}
in TestDirectorUtils.pm. Do you need to pass an additional argument to
td_interface.pl that specifies the version number, which will then be
passed to TestDirectorUtils.pm ?
(3) The url
http://aspn.activestate.com/ASPN/Mail/Messages/perl-win32-database/2720421
seems invalid now. I searched in the activestate bugtracker for "Win32::OLE
fork" and found the following:
http://bugs.activestate.com/buglist.cgi?querytype=simple&type%
3Ashort_desc%3Along_desc%3Abug_file_loc%3Astatus_whiteboard%
3Akeywords=substring&OR%3Ashort_desc%3Along_desc%3Abug_file_loc%
3Astatus_whiteboard%3Akeywords=Win32%3A%3AOLE
+fork&submit=Search&bug_status=UNCONFIRMED&bug_status=NEW&bug_status=ASSIGNED&bug_status=REOPENED&bug_status=RESOLVED&bug_status=VERIFIED&bug_status=CLOSED&bug_status=LIMITATION
I'll try to add one of the bugs listed there as the link. Do you have
another link ?
(4) We need a way to check if Win32::OLE exists installed on the system.
I'm guessing that if we try to include it to test if it exists, using
Common.pm:package_exists like the Bugzilla.pm backend, then you see a
crash later on. Is that correct ? Any ideas on what we could do ?
Perhaps TestDirectorUtils.pm could provide a function that lets us check
if the module is installed ?
(5) In the td_bug_status_map, I noticed the string:
"PAG Invalid Defct"
should the string be:
"PAG Invalid Defect"
??
On Fri, 2006-12-15 at 03:25 -0800, Robert Hudson wrote:
> Hi,
>
> Please find attached the additions for the manual on the Test Director
> additions.
>
> Thanks
>
> Rob
_______________________________________________
scmbug-users mailing list
[email protected]
http://lists.mkgnu.net/cgi-bin/mailman/listinfo/scmbug-users
