Hi Kristis,
Thanks for the speedy integration. I'll E-mail you a private zip with
my next set of updates based on what you have sent me. I'll try and
address your comments as well.
(1) I agree. I have now created a separate config file
"TestDirector.conf" which is read in from within the TestDirector
specific code, and it uses the bugtracker->{ installation_directory }
for where this file resides (One of the problems is that Test Director
will almost always exist on a different machine, so there is no default
directory to store this). What I thought is that we could have the
sample one stored in "etc/scmbug/" so there is a starting point for
users.
I think it is essential that we keep these values out of the Perl
library files as every users system will need different values and I
think it makes more sense for users to update a config file rather then
the actual perl library files. (Also will make upgrade easier). I will
try and get to some updated manual text to explain the config file.
(2) Yes, that is correct about the OLE Bug. Not sure about the version
bit, not 100% sure what and when the version is checked. All Requests
that get to TestDirectorUtils.pm go via TestDirector.pm which has the
version check in it. Is this cover enough?
(3) Oops ... The following link should be just as good:
http://bugs.activestate.com/show_bug.cgi?id=38968
(4) Not an area I know anything about - sorry!
(5) Oops typo ... Corrected.
I have made a first stab at the extra method for the merge, in principle
it seems to be OK but there is one problem. Test Director stores all of
the commit comments (and files changed) in one memo field (not separate
rows in a DB like bugzilla). The code that I have added tries to pass
all of that to the extract_affected_files() method but it only strips
out the files from the last commit (And treats all the previous ones as
comments). So this gives us two choices for this:
(A) Update extract_affected_files() so that it can extract multiple
sections out of the text passed to it.
(B) Pre-parse the text to split the commits into separate transactions
and pass them in separately to extract_affected_files().
Obviously I prefer (A) :-) [Didn't know if other systems would hit the
same problem] But didn't know if this was possible to do it there, what
did you think?
Thanks
Rob
> -----Original Message-----
> From: Kristis Makris [mailto:[EMAIL PROTECTED]
> Sent: 15 December 2006 20:36
> To: Robert Hudson
> Cc: [email protected]
> Subject: RE: SCMBug and Test Director (Version 9.0)
>
> Hi Rob, thanks for the patches.
>
> I will be sending you a private release (.zip file) you could retest.
>
> I started going over them and trying to merge. You did A LOT
> OF HARD WORK. Some comments I have:
>
> (1) testdirector_config does not belong in daemon.conf. It
> belongs somewhere on the filesystem where TestDirector is
> installed. I would assume that TestDirector already provides
> some "other" configuration file that describes all these
> settings. The backend should read them from that file. It can
> use bugtracker->{ installation_directory } to pick up the
> installation directory of TestDirector and append to it the
> path to that configuration file.
>
> NOTE: This is a much bigger problem in Scmbug in general.
> Both Mantis and Bugzilla hardcode their configuration
> settings in their source code, instead of some configuration
> file, or the database. As a result, Scmbug currently
> hardcodes in the backend itself these values; if a user needs
> to customize them, they must modify the backend. If they want
> this more configurable, they must request these options to be
> more configurable to the developers of the bugtracker.
>
> So, for TestDirector, I removed those settings from the
> daemon, and hardcoded them in the backend. If TestDirector
> has a more flexible way of reading them, maybe parsing them
> from another file, then that's great. But they don't belong
> in daemon.conf.
>
> (2) If I'm understanding this correctly, TestDirectorUtils.pm
> exists because of the OLE bug, right ? One thing that worries
> me is that it does not contain version information. So when
> TestDirector 10.0 comes out and the interface changes you
> won't be able to say:
>
> if (is_version_latest()) {
> } else {
> }
>
> in TestDirectorUtils.pm. Do you need to pass an additional
> argument to td_interface.pl that specifies the version
> number, which will then be passed to TestDirectorUtils.pm ?
>
> (3) The url
> http://aspn.activestate.com/ASPN/Mail/Messages/perl-win32-data
> base/2720421 seems invalid now. I searched in the activestate
> bugtracker for "Win32::OLE fork" and found the following:
>
> http://bugs.activestate.com/buglist.cgi?querytype=simple&type%
> 3Ashort_desc%3Along_desc%3Abug_file_loc%3Astatus_whiteboard%
> 3Akeywords=substring&OR%3Ashort_desc%3Along_desc%3Abug_file_loc%
> 3Astatus_whiteboard%3Akeywords=Win32%3A%3AOLE
> +fork&submit=Search&bug_status=UNCONFIRMED&bug_status=NEW&bug_
> status=ASS
> +IGNED&bug_status=REOPENED&bug_status=RESOLVED&bug_status=VERI
> FIED&bug_s
> +tatus=CLOSED&bug_status=LIMITATION
>
> I'll try to add one of the bugs listed there as the link. Do
> you have another link ?
>
> (4) We need a way to check if Win32::OLE exists installed on
> the system.
> I'm guessing that if we try to include it to test if it
> exists, using Common.pm:package_exists like the Bugzilla.pm
> backend, then you see a crash later on. Is that correct ? Any
> ideas on what we could do ?
> Perhaps TestDirectorUtils.pm could provide a function that
> lets us check if the module is installed ?
>
> (5) In the td_bug_status_map, I noticed the string:
>
> "PAG Invalid Defct"
>
> should the string be:
>
> "PAG Invalid Defect"
>
> ??
>
>
> On Fri, 2006-12-15 at 03:25 -0800, Robert Hudson wrote:
> > Hi,
> >
> > Please find attached the additions for the manual on the
> Test Director
> > additions.
> >
> > Thanks
> >
> > Rob
>
>
_______________________________________________
scmbug-users mailing list
[email protected]
http://lists.mkgnu.net/cgi-bin/mailman/listinfo/scmbug-users
