Hi Dmitri, On Mon, 2007-06-04 at 12:12 +1000, Dmitri Colebatch wrote: > I'm now ready to take a look at this. Kristis, could you give me a > little guidance please? I've read through
I haven't used Bugzilla 3.0 at all and I'm not familiar with the API changes. > http://bugzilla.mkgnu.net/show_bug.cgi?id=948 and assume that > Scmbug/Daemon/Bugzilla.pm should be the only thing that needs > changing. From there, I should make use of the bugzilla interfaces, > rather than going direct to the database. This is where I'm a little > unsure of the best approach.... the whole Bugzilla.pm file seems to > assume that we'll be going direct to the database, it seems that it'll > be some pretty messy code to use that as a base. Would a Bugzilla3.pm > be workable? (I have no idea what the best approaches to perl are). Here are some thoughts I have: 1 - use lib "path_to_bugzilla"; That' won't work. You don't know where people have installed Bugzilla 3.0. If you examine Bugzilla.pm.in:init_specific you'll see there use of: # Include the bugzilla libraries push @INC, $self->installation_directory(); chdir $self->installation_directory(); 2 - Why create a Bugzilla3.pm ? It's not necessary. I would claim breaking it up will cause things missing in Bugzilla3.pm when new integration_* functions are added (e.g. as they have been added right now in a patch I've been working on for autolinkification) -- why maintain essentially an extra backend, and duplicate code ? It's not "messy code". It a concise design. I'd rather you integrated the 3.0 work in the existing Bugzilla.pm. A Bugzilla3.pm would be workable, but I feel it would cause more problems than the ones it attempts to solve. > Secondly, looking at http://www.bugzilla.org/docs/tip/html/api/ there > is no mention of Bugzilla::Bug - am I missing something here? The > code runs fine up to line 46: > print "pid:".$product->id."\n"; > but generally the concept looks good. I don't have time to look into this :) > I'd like to do this this week, so if people can help me with the above > we should be able to have some sort of bugzilla 3 support soon.
signature.asc
Description: This is a digitally signed message part
_______________________________________________ scmbug-users mailing list [email protected] http://lists.mkgnu.net/cgi-bin/mailman/listinfo/scmbug-users
