Hi Oliver, The tests didn't pass, no. Have a look at
system/src/tests/product.test/svn/SVN_VERSION_1_4_x/Scmbug.log for details Thanks for the patch, but I can't accept it as is. Because the error of an invalid product name should be handled outside the function integration_tag_exists. If this function returns 0 just because the product name did not exist, it will communicate the wrong message to its caller: that the tag did not exist - even though the tag did exist for a product name, or the product name the user thought was already being supplied. Instead the check for a valid product name, before attempting to add/delete tags, should be handled in a manner similar to the one implemented in Integration.pm.in:process_activity_verify. Additionally, this patch only fixes this issue for Bugzilla 3.0, not for all versions of bugzilla, and all other bugtracking systems that may suffer from the same error of tagging when valid_product_name is disabled and an invalid product name is defined. On Thu, 2007-10-18 at 15:49 +0200, Oliver Schäfer wrote: > Again me:-) > > > http://bugzilla.mkgnu.net/show_bug.cgi?id=948 > > http://bugzilla.mkgnu.net/show_bug.cgi?id=1052 > > > Attached a small patch to Bugzilla.pm.in > Tests still not passing: > > FAIL: Install Glue supplying a wrong daemon ip > UNRESOLVED: Commit a file with single quotes in the comment > UNRESOLVED: Commit a file with double quotes in the comment > FAIL: Create a VDD > > >
signature.asc
Description: This is a digitally signed message part
_______________________________________________ scmbug-users mailing list [email protected] http://lists.mkgnu.net/cgi-bin/mailman/listinfo/scmbug-users
