We don't return negative values anywhere. Lets maintain that for consistency. Lets return 2.
On Fri, 2007-10-19 at 07:24 +0200, Oliver Schäfer wrote: > Hello Kristis, > > you are right. > > Anyway we need to catch/throw exceptions within a method. So I would > like to return an error at least. > What about using negative return values, or something like (-1, "Err > message") ? > > For instance in integration_tag_exists: > 1: Exists > 0: Does not exist > -1: Error > > -- > Oliver > > > On Oct 18, 2007, at 9:23 , Kristis Makris wrote: > > > Instead the check for a valid product name, before attempting to > > add/delete > > tags, should be handled in a manner similar to the one implemented in > > Integration.pm.in:process_activity_verify. > > > > Additionally, this patch only fixes this issue for Bugzilla 3.0, > > not for all > > versions of bugzilla, and all other bugtracking systems that may > > suffer from > > the same error of tagging when valid_product_name is disabled and > > an invalid > > product name is defined. >
signature.asc
Description: This is a digitally signed message part
_______________________________________________ scmbug-users mailing list [email protected] http://lists.mkgnu.net/cgi-bin/mailman/listinfo/scmbug-users
