To list -------- Forwarded Message -------- From: Doug McNeil <[EMAIL PROTECTED]> Reply-To: [EMAIL PROTECTED] To: Kristis Makris <[EMAIL PROTECTED]> Subject: Re: [scmbug-users] .scmbug_consolidated_cvs_activities files are not removed Date: Thu, 07 Feb 2008 15:45:03 -0500
Kristis, The if block on 197 should always exit(0) by the looks of things. It happens on "commit" and the user data is persisted to temp file. So, I do not think line 205 is wrong, but should be clean up (one exit(0) at end of if). Doug Kristis Makris wrote: > It also seems that if one sets consolidated_cvs_activities => 0 then a > commit activity simply exits: > > e.g. line 205 in: > > http://www.mkgnu.net/cgi-bin/viewcvs.cgi/scmbug/cvsroot/system/src/lib/product/Glue/CVS.pm.in?annotate=1.33 > > I just verified this by running the testsuite. > > I suppose we need the capability to consolidate CVS activities to be > configurable. Instead, this feature has completely broken CVS support > for someone who does not wish to use log message consolidation. > > Doug, another question: why do we need the if check at line 197 ? We are > passing this additional argument from the hook, thus it should always be > there, right ? > > If I remove the exit in line 205, then committing just freezes. > > Doug, could you have another look at this work please ? > > Thanks, > Kristis > > On Thu, 2008-02-07 at 11:42 -0700, Kristis Makris wrote: > >> Doug, it seems that these files are not removed. Do you also experience >> this ? Do you have a solution ? >> >> http://bugzilla.mkgnu.net/show_bug.cgi?id=1119 >> _______________________________________________ >> scmbug-users mailing list >> [email protected] >> http://lists.mkgnu.net/cgi-bin/mailman/listinfo/scmbug-users >>
signature.asc
Description: This is a digitally signed message part
_______________________________________________ scmbug-users mailing list [email protected] http://lists.mkgnu.net/cgi-bin/mailman/listinfo/scmbug-users
