To the list -------- Forwarded Message -------- From: Doug McNeil <[EMAIL PROTECTED]> Reply-To: [EMAIL PROTECTED] To: Kristis Makris <[EMAIL PROTECTED]> Subject: Re: [scmbug-users] .scmbug_consolidated_cvs_activities files are not removed Date: Thu, 07 Feb 2008 16:30:26 -0500
Kristis,
I do not think the exit(0) on line 222 of CVS.pm is the problem.
The logic is:
Reference count "activities" on "commits" - the "add" at line 202
Dereference count "activities" on "loginfos" - the "replace" at line 221
if (reference count = 0) consolidate() else exit(0)
The temp file delete code is in the DESTROY destructor of
"CVSConsolidatedActivities.pm". Whenever the activity reference count
goes to 0 the temp file is deleted (line 167). Is there an extra
"commit" happening? One not balanced by a "loginfo"? Maybe some weird
race condition of two sessions of the same user happening that
unbalances the "adds" and "replaces"? I tried to make things as immune
to things like that by making the temp files as uniquely named as
possible, but it is a possibility. Another possibility might be some
type of failure on the "loginfo" action pass through that exits before
the "replace" happens?
Doug
Kristis Makris wrote:
> Douf, actually the error seems to be in line 222:
>
> http://www.mkgnu.net/cgi-bin/viewcvs.cgi/scmbug/cvsroot/system/src/lib/product/Glue/CVS.pm.in?annotate=1.33
>
> We simply exit there. Why ?
>
> What does the if statement check for ?
>
> http://bugzilla.mkgnu.net/show_bug.cgi?id=1043
>
>
>
> Manjit, a preliminary fix that seems to work (it may NOT) for me is to
> comment out the exit statement in line 222. Perhaps you could try that
> along with setting consolidate_cvs_messages => 0 ?
>
signature.asc
Description: This is a digitally signed message part
_______________________________________________ scmbug-users mailing list [email protected] http://lists.mkgnu.net/cgi-bin/mailman/listinfo/scmbug-users
