Hey Doug thanks for the help. Please forward all communication to the mailing list.
There are 2 problems: 1) The .scmbug_consolidated_cvs_activities_files are not deleted. 2) If consolidate_cvs_activities is set to 0, all CVS commits whatsoever do not issue a commit activity. That's because they exit, at line 222. So, it seems that when consolidate_cvs_activities is set to 1, "things work for most people" -- I am still not sure what's the case with Manjit. But I'm more interested in debugging (2) first. Let's worry about (1) a little later. I wish this work can become more readable. Meaning remove DESTROY, and instead issue precisely the function calls needed, precisely where they are need. > From: Doug McNeil <[EMAIL PROTECTED]> > I do not think the exit(0) on line 222 of CVS.pm is the problem. > > The logic is: > Reference count "activities" on "commits" - the "add" at line 202 > Dereference count "activities" on "loginfos" - the "replace" at line 221 > if (reference count = 0) consolidate() else exit(0) I think this might be the error. You say exit(0), but I tried to conditionally execute this code if the policy is enabled, and this exit is executed when the policy is disabled, too. This may be it. Can you have a look at the code as is in the repository right now ? Should the if statement in line 225 include line 221 in its scope ? > "commit" happening? One not balanced by a "loginfo"? Maybe some weird > race condition of two sessions of the same user happening that > unbalances the "adds" and "replaces"? I tried to make things as immune Manjit is running this on Windows, whose ActiveState Perl implementation does not provide a getppid(). Sessions probably become unbalanced because instead of a getppid() number he gets back the string "getppid" (Scmbug code did that). So I'd like him to disable this policy, but then commits are not issued, because of the exit in line 222.
signature.asc
Description: This is a digitally signed message part
_______________________________________________ scmbug-users mailing list [email protected] http://lists.mkgnu.net/cgi-bin/mailman/listinfo/scmbug-users
