> On Tue, 2009-06-30 at 18:43 +0100, Uditha Atukorala wrote:
> > Another patch. This is now working with status changes as well. 

What does "working with status changes" mean ?

The patch lacks documentation related to this. For example, it adds
support for 3.2, but I believe it breaks the status support for 3.0 in
bug_status_map(). It only accounts for is_version_latest(). How about
the Bugzilla 3.0 users ? Will we ignore them, just because we want to
use 3.2 ?

Why do you not use Bugzilla::Bug::is_open_state() and instead use
Bugzilla::Status::is_open() ? Is the latter function not available in
Bugzilla 3.0 ? Is at available in both ?

A patch without documentation, and a commit log message, cannot be
applied.



Attachment: signature.asc
Description: This is a digitally signed message part

_______________________________________________
scmbug-users mailing list
[email protected]
http://lists.mkgnu.net/cgi-bin/mailman/listinfo/scmbug-users

Reply via email to