On Sun, 2010-04-04 at 00:47 +0300, Yavor Nikolov wrote:
> Hi Kristis,
>
> (1) Replacing bz_{lock,unlock}_tables with
> bz_{start,commit,rollback}_transaction prevented the error from
> occurring and seemed updating to RESOLVED FIXED worked fine. (I
> haven't tested other scenarios).
Is the use of "eval" in line 570, and of $@ necessary ? Could this be
written more clearly ?
If there is a possibility for Bugzilla to raise exceptions inside the
eval {} blocks, is there another way of eliminating that possibility ?
> * Looking at scmbug Bugzilla.pm tracker code (and the modified method
> in particular) - things are getting much bloated with these many
> version-specific if/else if cases. I just wonder - wouldn't it be
> better to just refactor version-specific code as separate sub-classes
> (the right one instantiated by Daemon depending on specified version;
> or on specified class name)? That would make things look simpler and
> easier to maintain - at least for the most recent bugtracker versions.
It would be better in some respects. I don't currently consider the
if/else cases to be a problem.
signature.asc
Description: This is a digitally signed message part
_______________________________________________ scmbug-users mailing list [email protected] http://lists.mkgnu.net/cgi-bin/mailman/listinfo/scmbug-users
