Hi Yavor.

On Sun, 2010-04-18 at 19:02 +0300, Yavor Nikolov wrote:
> Hi Kristis,
> 
> I'm sharing my current cumulative patch on top of scmbug 0.26.17 which
>
>
>  we're using on our environment with Bugzilla 3.6 (final) and 3.4.6. 
>  - Added support for Bugzilla 3.6 version number
>  - Same fix for status & resolution with Bugzilla 3.2+ (a bit
> reformatted and simplified)
>  - Same fix with eval block around comment adding (a bit reformatted
> and a bit simplified as per Max's comments)

It doesn't seem simplified. For example, the eval{} block still includes
most of the source, instead of just the call to check().

>  - A bit extended revision of my old patch for Bugzilla e-mail
> notification (http://bugzilla.mkgnu.net/show_bug.cgi?id=832). I've bee
> using that since an year with no problems. Following daemon.conf --
> bugtracker parameters should be added to enable it:
>     notification_enabled => 1 # bugtracker e-mail notification enabled
>     changer_notification_enabled => 1 # notify bug changer too

Hold it right there...

You are mixing multiple things in this patch. Bugzilla e-mail
notifications are a separate issue from status resolution. They
shouldn't be part of this patch. 

Attachment: signature.asc
Description: This is a digitally signed message part

_______________________________________________
scmbug-users mailing list
[email protected]
http://lists.mkgnu.net/cgi-bin/mailman/listinfo/scmbug-users

Reply via email to