Hi folks,

thanks for the release 0.26.19 - the daemon now starts and runs without 
problems.

However, we have found that in a commit to SVN the comment must not 
contain any special characters like e.g. German umlauts.

Unless, the comment will show up in Bugzilla, but it will be truncated at 
the first special character, and not show which files were affected by the 
commit.

It seems to me that this is the behavior as previously described in

http://bugzilla.mkgnu.net/show_bug.cgi?id=580

It struck me that several comments were truncated the same way our 
comments get truncated if they contain non-ASCII characters:

http://bugzilla.mkgnu.net/show_bug.cgi?id=580#c21
http://bugzilla.mkgnu.net/show_bug.cgi?id=580#c22
http://bugzilla.mkgnu.net/show_bug.cgi?id=580#c23

So this problem appears to be there even on your very own production 
machine...

For instance, if you commit some changes to SVN with a comment that says

        bla bla blö funktionieren die umlaute jetzt? bli bla blü

you would expect to find something like this in Bugzilla (real names 
replaced by <tags>):

        bla bla blö funktionieren die umlaute jetzt? bli bla blü


        Branch:        <component-name>/trunk
        Affected files:
        ---------------
        3111 --> 3112 
<product-name>:<component-name>/trunk/com.daimler.etc/src/com/daimler/etc/SomeClass.java

In contrast to this, we have found that comments in Bugzilla look like 
this:

        bla bla bl

Trying to track the reason down, I have tried to follow the comment's way 
from SVN through svmbug to Bugzilla:

pre-commit.bat calls scmbug_activity.pl calls Glue->process() calls 
Connection->process_activity() calls Connection->submit_request() opens a 
Socket and sends the comment (and other stuff) to the Daemon

Daemon->connection_handler_thread() calls Process->process_connection() 
calls Integration->process_activity_ commit() calls 
Integration->add_comment_to_all() calls 
Bugzilla->integration_add_comment()

In this method, a Bugzilla::Bug object is created, the comment is passed 
to it by calling Bug->add_comment() and finally Bug->update(). All this 
happens inside a transaction.

Since this seems to be the point where the comment "leaves" scmbug, I have 
inserted a log statement just before this happens:

Scmbug::Daemon::Bugzilla line 621ff:

    } else {
        # The bug id exists
 
        # inserted by mk
        log_daemon_warn( undef, "in Bugzilla->integration_add_comment, the 
comment was: " . $comment . "\n" );
 
        $dbh->bz_start_transaction();
        $bug->add_comment( $comment, {isprivate => 0, work_time => 0, type 
=> Bugzilla::Constants->CMT_NORMAL, extra_data => ""} );
        $bug->update();
        $dbh->bz_commit_transaction();
 
        return 0;
    }

And here is the output in activity.log:

2010/07/22 15:02:40 Scmbug WARN> 
Daemon.pm:659:Scmbug::Daemon::Daemon::connection_handler_thread - 
127.0.0.1:17866 Processing connection from   
2010/07/22 15:02:40 Scmbug WARN> 
Process.pm:868:Scmbug::Daemon::Process::process_activity_commit - 
127.0.0.1:17866 Processing an 'activity_commit' for bug id '1' from SCM 
user 'MK'
2010/07/22 15:02:40 Scmbug WARN> 
Bugzilla.pm:625:Scmbug::Daemon::Bugzilla::integration_add_comment - in 
Bugzilla->integration_add_comment, the comment was: bla bla blö 
funktionieren die umlaute jetzt? bli bla blü


Branch:        <component-name>/trunk
Affected files:
---------------
3111 --> 3112 
<product-name>:<component-name>/trunk/com.daimler.etc/src/com/daimler/etc/SomeClass.java

2010/07/22 15:02:40 Scmbug WARN> 
Daemon.pm:674:Scmbug::Daemon::Daemon::connection_handler_thread - 
127.0.0.1:17866 Connection from    processed



At this point, the comment still seems to be intact. The special 
characters are there and the Branch and Affected files info is present, 
nothing unusual.

Can we conclude from this that the problem lies within Bugzilla?

And if so, why would Bugzilla work while entering special characters via 
the Web interface? As it does....

In the end, all three pieces (SVN, scmbug and Bugzilla) run on the same 
machine...

Additional info:

OS: Windows XP
Bugzilla 3.4.7
scmbug 0.26.19
ActivePerl 5.8
VisualSVN Server 2.1.3 (includes Subversion 1.6.12)
Apache 2.2


Does anyone have a clue how to get this fixed or how to proceed in order 
to track the error further down?

Mit freundlichen Grüßen/Kind regards

Markus Kling
Software Architect

Daimler TSS GmbH
Consulting
Wilhelm-Runge-Strasse 11
89081 Ulm/Germany 

Phone +49–(0)731 / 5 05-63 05
Mobile +49-(0)160 / 86 77 433
Fax +49–(0)711 / 30 52 18 01 79

mailto:[email protected]

http://www.daimler-tss.com

 

Daimler TSS GmbH
Sitz und Registergericht/Domicile and Register Court: Ulm, 
HRB-Nr./Commercial Register No.: 3844 
Geschäftsführung/Management: Gerhard Streit (Vorsitzender/Chairperson), 
Dr. Stefan Eberhardt
Beiratsvorsitzende/Chairperson of the Advisory Board: Dr. Helmut Mahler

If you are not the intended addressee, please inform us immediately that you 
have received this e-mail in error, and delete it. We thank you for your 
cooperation.  
_______________________________________________
scmbug-users mailing list
[email protected]
http://lists.mkgnu.net/cgi-bin/mailman/listinfo/scmbug-users

Reply via email to