[jira] [Commented] (XERCESC-2194) Including Xerces_autoconf_config.hpp on Windows fails due to undefined ssize_t
[ https://issues.apache.org/jira/browse/XERCESC-2194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17052120#comment-17052120 ] Scott Cantor commented on XERCESC-2194: --- Isn't that the autotools-specific header? You would never include any of them directly, but if it's being included by mistake perhaps there's an issue somewhere around the guarding macros. > Including Xerces_autoconf_config.hpp on Windows fails due to undefined ssize_t > -- > > Key: XERCESC-2194 > URL: https://issues.apache.org/jira/browse/XERCESC-2194 > Project: Xerces-C++ > Issue Type: Bug > Components: Build >Affects Versions: 3.2.2 >Reporter: Rasmus Thomsen >Priority: Major > > When including Xerces_autoconf_config.hpp on Windows the following error > messages: > > {code:cpp} > error C4430: Fehlender Typspezifizierer - int wird angenommen. Hinweis: > "default-int" wird von C++ nicht unterstützt. > error C2146: Syntaxfehler: Fehlendes ";" vor Bezeichner "XMLSSize_t" > {code} > (Sorry that these are in German - they translate to "Missing type specifier - > assuming int" and "syntax error: missing ";" before identifier "XMLSSize_t") > Apparently ssize_t is a POSIX extension and as such isn't available in MSVC > (by default?) -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: c-dev-unsubscr...@xerces.apache.org For additional commands, e-mail: c-dev-h...@xerces.apache.org
[jira] [Created] (XERCESC-2194) Including Xerces_autoconf_config.hpp on Windows fails due to undefined ssize_t
Rasmus Thomsen created XERCESC-2194: --- Summary: Including Xerces_autoconf_config.hpp on Windows fails due to undefined ssize_t Key: XERCESC-2194 URL: https://issues.apache.org/jira/browse/XERCESC-2194 Project: Xerces-C++ Issue Type: Bug Components: Build Affects Versions: 3.2.2 Reporter: Rasmus Thomsen When including Xerces_autoconf_config.hpp on Windows the following error messages: {code:cpp} error C4430: Fehlender Typspezifizierer - int wird angenommen. Hinweis: "default-int" wird von C++ nicht unterstützt. error C2146: Syntaxfehler: Fehlendes ";" vor Bezeichner "XMLSSize_t" {code} (Sorry that these are in German - they translate to "Missing type specifier - assuming int" and "syntax error: missing ";" before identifier "XMLSSize_t") Apparently ssize_t is a POSIX extension and as such isn't available in MSVC (by default?) -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: c-dev-unsubscr...@xerces.apache.org For additional commands, e-mail: c-dev-h...@xerces.apache.org
[jira] [Commented] (XERCESC-2194) Including Xerces_autoconf_config.hpp on Windows fails due to undefined ssize_t
[ https://issues.apache.org/jira/browse/XERCESC-2194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17052151#comment-17052151 ] Scott Cantor commented on XERCESC-2194: --- Ack, and same goes for VS2017. > Including Xerces_autoconf_config.hpp on Windows fails due to undefined ssize_t > -- > > Key: XERCESC-2194 > URL: https://issues.apache.org/jira/browse/XERCESC-2194 > Project: Xerces-C++ > Issue Type: Bug > Components: Build >Affects Versions: 3.2.2 >Reporter: Rasmus Thomsen >Priority: Major > > When including Xerces_autoconf_config.hpp on Windows the following error > messages: > > {code:cpp} > error C4430: Fehlender Typspezifizierer - int wird angenommen. Hinweis: > "default-int" wird von C++ nicht unterstützt. > error C2146: Syntaxfehler: Fehlendes ";" vor Bezeichner "XMLSSize_t" > {code} > (Sorry that these are in German - they translate to "Missing type specifier - > assuming int" and "syntax error: missing ";" before identifier "XMLSSize_t") > Apparently ssize_t is a POSIX extension and as such isn't available in MSVC > (by default?) -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: c-dev-unsubscr...@xerces.apache.org For additional commands, e-mail: c-dev-h...@xerces.apache.org
[jira] [Comment Edited] (XERCESC-2194) Including Xerces_autoconf_config.hpp on Windows fails due to undefined ssize_t
[ https://issues.apache.org/jira/browse/XERCESC-2194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17052139#comment-17052139 ] Scott Morgan edited comment on XERCESC-2194 at 3/5/20, 1:36 PM: It's generated by CMake, and should define XMLSSize_t to long, via a XERCES_SSIZE_T define in all in that file Or at least that's what it does on my VC2019 Win32 build. was (Author: blumf): It's generated by CMake, and should define XMLSSize_t to long, via a XERCES_SSIZE_T define in all in that file Or at least that's what it does on my system. > Including Xerces_autoconf_config.hpp on Windows fails due to undefined ssize_t > -- > > Key: XERCESC-2194 > URL: https://issues.apache.org/jira/browse/XERCESC-2194 > Project: Xerces-C++ > Issue Type: Bug > Components: Build >Affects Versions: 3.2.2 >Reporter: Rasmus Thomsen >Priority: Major > > When including Xerces_autoconf_config.hpp on Windows the following error > messages: > > {code:cpp} > error C4430: Fehlender Typspezifizierer - int wird angenommen. Hinweis: > "default-int" wird von C++ nicht unterstützt. > error C2146: Syntaxfehler: Fehlendes ";" vor Bezeichner "XMLSSize_t" > {code} > (Sorry that these are in German - they translate to "Missing type specifier - > assuming int" and "syntax error: missing ";" before identifier "XMLSSize_t") > Apparently ssize_t is a POSIX extension and as such isn't available in MSVC > (by default?) -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: c-dev-unsubscr...@xerces.apache.org For additional commands, e-mail: c-dev-h...@xerces.apache.org
[jira] [Commented] (XERCESC-2194) Including Xerces_autoconf_config.hpp on Windows fails due to undefined ssize_t
[ https://issues.apache.org/jira/browse/XERCESC-2194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17052139#comment-17052139 ] Scott Morgan commented on XERCESC-2194: --- It's generated by CMake, and should define XMLSSize_t to long, via a XERCES_SSIZE_T define in all in that file Or at least that's what it does on my system. > Including Xerces_autoconf_config.hpp on Windows fails due to undefined ssize_t > -- > > Key: XERCESC-2194 > URL: https://issues.apache.org/jira/browse/XERCESC-2194 > Project: Xerces-C++ > Issue Type: Bug > Components: Build >Affects Versions: 3.2.2 >Reporter: Rasmus Thomsen >Priority: Major > > When including Xerces_autoconf_config.hpp on Windows the following error > messages: > > {code:cpp} > error C4430: Fehlender Typspezifizierer - int wird angenommen. Hinweis: > "default-int" wird von C++ nicht unterstützt. > error C2146: Syntaxfehler: Fehlendes ";" vor Bezeichner "XMLSSize_t" > {code} > (Sorry that these are in German - they translate to "Missing type specifier - > assuming int" and "syntax error: missing ";" before identifier "XMLSSize_t") > Apparently ssize_t is a POSIX extension and as such isn't available in MSVC > (by default?) -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: c-dev-unsubscr...@xerces.apache.org For additional commands, e-mail: c-dev-h...@xerces.apache.org
[jira] [Commented] (XERCESC-2188) Use-after-free on external DTD scan
[ https://issues.apache.org/jira/browse/XERCESC-2188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17052244#comment-17052244 ] Scott Cantor commented on XERCESC-2188: --- Noting, Red Hat just shipped a "fix" for this backported to 3.0 and the fix is simply to remove the Janitors around the objects causing the problem, as far as I can tell. It's possible this is even correct if they're being freed independently at the right spot, but I don't know the code well enough to tell that. Just for posterity: {code} https://bugzilla.redhat.com/show_bug.cgi?id=CVE-2018-1311 --- xerces-c-3.0.1/src/xercesc/internal/IGXMLScanner.cpp.cve1311 +++ xerces-c-3.0.1/src/xercesc/internal/IGXMLScanner.cpp @@ -1533,7 +1533,6 @@ DTDEntityDecl* declDTD = new (fMemoryManager) DTDEntityDecl(gDTDStr, false, fMemoryManager); declDTD->setSystemId(sysId); declDTD->setIsExternal(true); -Janitor janDecl(declDTD); // Mark this one as a throw at end reader->setThrowAtEnd(true); @@ -3154,7 +3153,6 @@ DTDEntityDecl* declDTD = new (fMemoryManager) DTDEntityDecl(gDTDStr, false, fMemoryManager); declDTD->setSystemId(src.getSystemId()); declDTD->setIsExternal(true); -Janitor janDecl(declDTD); // Mark this one as a throw at end newReader->setThrowAtEnd(true); {code} > Use-after-free on external DTD scan > --- > > Key: XERCESC-2188 > URL: https://issues.apache.org/jira/browse/XERCESC-2188 > Project: Xerces-C++ > Issue Type: Bug > Components: Validating Parser (DTD) >Affects Versions: 3.0.0, 3.0.1, 3.0.2, 3.1.0, 3.1.1, 3.1.2, 3.2.0, 3.1.3, > 3.1.4, 3.2.1, 3.2.2 >Reporter: Scott Cantor >Priority: Major > Attachments: Apache-496067-disclosure-report.pdf > > > This is a record of an unfixed bug reported in 2018 in the DTD scanner, per > the attached PDF, corresponding to CVE-2018-1311. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: c-dev-unsubscr...@xerces.apache.org For additional commands, e-mail: c-dev-h...@xerces.apache.org
[jira] [Commented] (XERCESC-2188) Use-after-free on external DTD scan
[ https://issues.apache.org/jira/browse/XERCESC-2188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17052252#comment-17052252 ] Scott Cantor commented on XERCESC-2188: --- Scanning the code further, it does not appear the entity "stack" in the ReaderMgr that these objects are pushed onto owns them or deletes them, so this appears to leak to me. But that's not authoritative, just noting for any future investigation. > Use-after-free on external DTD scan > --- > > Key: XERCESC-2188 > URL: https://issues.apache.org/jira/browse/XERCESC-2188 > Project: Xerces-C++ > Issue Type: Bug > Components: Validating Parser (DTD) >Affects Versions: 3.0.0, 3.0.1, 3.0.2, 3.1.0, 3.1.1, 3.1.2, 3.2.0, 3.1.3, > 3.1.4, 3.2.1, 3.2.2 >Reporter: Scott Cantor >Priority: Major > Attachments: Apache-496067-disclosure-report.pdf > > > This is a record of an unfixed bug reported in 2018 in the DTD scanner, per > the attached PDF, corresponding to CVE-2018-1311. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: c-dev-unsubscr...@xerces.apache.org For additional commands, e-mail: c-dev-h...@xerces.apache.org
[jira] [Commented] (XERCESC-2194) Including Xerces_autoconf_config.hpp on Windows fails due to undefined ssize_t
[ https://issues.apache.org/jira/browse/XERCESC-2194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1705#comment-1705 ] Scott Cantor commented on XERCESC-2194: --- I don't generally touch CMake, and will never do so do for any non-Windows builds but if the change fixes your issue and does not break my build I probably would consider applying it. > Including Xerces_autoconf_config.hpp on Windows fails due to undefined ssize_t > -- > > Key: XERCESC-2194 > URL: https://issues.apache.org/jira/browse/XERCESC-2194 > Project: Xerces-C++ > Issue Type: Bug > Components: Build >Affects Versions: 3.2.2 >Reporter: Rasmus Thomsen >Priority: Major > > When including Xerces_autoconf_config.hpp on Windows the following error > messages: > > {code:cpp} > error C4430: Fehlender Typspezifizierer - int wird angenommen. Hinweis: > "default-int" wird von C++ nicht unterstützt. > error C2146: Syntaxfehler: Fehlendes ";" vor Bezeichner "XMLSSize_t" > {code} > (Sorry that these are in German - they translate to "Missing type specifier - > assuming int" and "syntax error: missing ";" before identifier "XMLSSize_t") > Apparently ssize_t is a POSIX extension and as such isn't available in MSVC > (by default?) -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: c-dev-unsubscr...@xerces.apache.org For additional commands, e-mail: c-dev-h...@xerces.apache.org
[jira] [Updated] (XERCESC-2194) Including Xerces_autoconf_config.hpp on Windows fails due to undefined ssize_t
[ https://issues.apache.org/jira/browse/XERCESC-2194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Cantor updated XERCESC-2194: -- Fix Version/s: 3.2.3 > Including Xerces_autoconf_config.hpp on Windows fails due to undefined ssize_t > -- > > Key: XERCESC-2194 > URL: https://issues.apache.org/jira/browse/XERCESC-2194 > Project: Xerces-C++ > Issue Type: Bug > Components: Build >Affects Versions: 3.2.2 >Reporter: Rasmus Thomsen >Priority: Major > Fix For: 3.2.3 > > > When including Xerces_autoconf_config.hpp on Windows the following error > messages: > > {code:cpp} > error C4430: Fehlender Typspezifizierer - int wird angenommen. Hinweis: > "default-int" wird von C++ nicht unterstützt. > error C2146: Syntaxfehler: Fehlendes ";" vor Bezeichner "XMLSSize_t" > {code} > (Sorry that these are in German - they translate to "Missing type specifier - > assuming int" and "syntax error: missing ";" before identifier "XMLSSize_t") > Apparently ssize_t is a POSIX extension and as such isn't available in MSVC > (by default?) -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: c-dev-unsubscr...@xerces.apache.org For additional commands, e-mail: c-dev-h...@xerces.apache.org
[jira] [Assigned] (XERCESC-2194) Including Xerces_autoconf_config.hpp on Windows fails due to undefined ssize_t
[ https://issues.apache.org/jira/browse/XERCESC-2194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Cantor reassigned XERCESC-2194: - Assignee: Scott Cantor > Including Xerces_autoconf_config.hpp on Windows fails due to undefined ssize_t > -- > > Key: XERCESC-2194 > URL: https://issues.apache.org/jira/browse/XERCESC-2194 > Project: Xerces-C++ > Issue Type: Bug > Components: Build >Affects Versions: 3.2.2 >Reporter: Rasmus Thomsen >Assignee: Scott Cantor >Priority: Major > Fix For: 3.2.3 > > > When including Xerces_autoconf_config.hpp on Windows the following error > messages: > > {code:cpp} > error C4430: Fehlender Typspezifizierer - int wird angenommen. Hinweis: > "default-int" wird von C++ nicht unterstützt. > error C2146: Syntaxfehler: Fehlendes ";" vor Bezeichner "XMLSSize_t" > {code} > (Sorry that these are in German - they translate to "Missing type specifier - > assuming int" and "syntax error: missing ";" before identifier "XMLSSize_t") > Apparently ssize_t is a POSIX extension and as such isn't available in MSVC > (by default?) -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: c-dev-unsubscr...@xerces.apache.org For additional commands, e-mail: c-dev-h...@xerces.apache.org
[jira] [Commented] (XERCESC-2194) Including Xerces_autoconf_config.hpp on Windows fails due to undefined ssize_t
[ https://issues.apache.org/jira/browse/XERCESC-2194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17052225#comment-17052225 ] Rasmus Thomsen commented on XERCESC-2194: - Ah, sorry if it seemed otherwise but my proposed fix isn't tested yet - that was mostly what I read out of the CMake docs. I'll go ahead and test it tomorrow and submit a change if it works. Thanks for the help already! :) > Including Xerces_autoconf_config.hpp on Windows fails due to undefined ssize_t > -- > > Key: XERCESC-2194 > URL: https://issues.apache.org/jira/browse/XERCESC-2194 > Project: Xerces-C++ > Issue Type: Bug > Components: Build >Affects Versions: 3.2.2 >Reporter: Rasmus Thomsen >Assignee: Scott Cantor >Priority: Major > Fix For: 3.2.3 > > > When including Xerces_autoconf_config.hpp on Windows the following error > messages: > > {code:cpp} > error C4430: Fehlender Typspezifizierer - int wird angenommen. Hinweis: > "default-int" wird von C++ nicht unterstützt. > error C2146: Syntaxfehler: Fehlendes ";" vor Bezeichner "XMLSSize_t" > {code} > (Sorry that these are in German - they translate to "Missing type specifier - > assuming int" and "syntax error: missing ";" before identifier "XMLSSize_t") > Apparently ssize_t is a POSIX extension and as such isn't available in MSVC > (by default?) -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: c-dev-unsubscr...@xerces.apache.org For additional commands, e-mail: c-dev-h...@xerces.apache.org
[jira] [Commented] (XERCESC-2194) Including Xerces_autoconf_config.hpp on Windows fails due to undefined ssize_t
[ https://issues.apache.org/jira/browse/XERCESC-2194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17052442#comment-17052442 ] Roger Leigh commented on XERCESC-2194: -- Looking at https://cmake.org/cmake/help/v3.16/module/CheckTypeSize.html I agree that HAVE_ should be fine. However, I'm curious as to why the existing logic is not working for you. What is the value of SIZEOF_SSIZE_T if you print it out? Both "" and 0 should evaluate to false. That's my understanding of https://cmake.org/cmake/help/v3.0/command/if.html HAVE_ was present back to CMake 3.0, so there are no compatibility concerns to switching over. If you want to open a PR, I'll be happy to test. > Including Xerces_autoconf_config.hpp on Windows fails due to undefined ssize_t > -- > > Key: XERCESC-2194 > URL: https://issues.apache.org/jira/browse/XERCESC-2194 > Project: Xerces-C++ > Issue Type: Bug > Components: Build >Affects Versions: 3.2.2 >Reporter: Rasmus Thomsen >Assignee: Scott Cantor >Priority: Major > Fix For: 3.2.3 > > > When including Xerces_autoconf_config.hpp on Windows the following error > messages: > > {code:cpp} > error C4430: Fehlender Typspezifizierer - int wird angenommen. Hinweis: > "default-int" wird von C++ nicht unterstützt. > error C2146: Syntaxfehler: Fehlendes ";" vor Bezeichner "XMLSSize_t" > {code} > (Sorry that these are in German - they translate to "Missing type specifier - > assuming int" and "syntax error: missing ";" before identifier "XMLSSize_t") > Apparently ssize_t is a POSIX extension and as such isn't available in MSVC > (by default?) -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: c-dev-unsubscr...@xerces.apache.org For additional commands, e-mail: c-dev-h...@xerces.apache.org
[jira] [Commented] (XERCESC-2163) XercesMessages_en_US.cat is installed to wrong directory
[ https://issues.apache.org/jira/browse/XERCESC-2163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17052453#comment-17052453 ] Roger Leigh commented on XERCESC-2163: -- [~candrews] With the switchover of Xerces-C to git, it looks like your PR got lost when the mirror was switched over to the real repo. Please could you reopen your PR against the new repository. Thanks! > XercesMessages_en_US.cat is installed to wrong directory > > > Key: XERCESC-2163 > URL: https://issues.apache.org/jira/browse/XERCESC-2163 > Project: Xerces-C++ > Issue Type: Bug > Components: Build >Affects Versions: 3.2.0, 3.2.1, 3.2.2 >Reporter: Craig >Assignee: Roger Leigh >Priority: Major > Labels: cmake > Fix For: 3.2.3 > > > When building with the > {code}-Dmessage-loader=iconv{code} > cmake option, {{XercesMessages_en_US.cat}} is installed to: > {{/usr/msg/}} > It should be installed to: > {{/usr/share/xerces-c/msg/}} > which is what previous versions of Xerces-C did. > This change breaks downstream consumers of Xerces-C, such as Xalan-C (which > fails to build as it cannot find {{XercesMessages_en_US.cat}}). > Originally reported at https://bugs.gentoo.org/673548 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: c-dev-unsubscr...@xerces.apache.org For additional commands, e-mail: c-dev-h...@xerces.apache.org
[jira] [Commented] (XERCESC-2138) Xerces-C++ should use C++98 features and remove pre-Standard workarounds
[ https://issues.apache.org/jira/browse/XERCESC-2138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17052445#comment-17052445 ] Roger Leigh commented on XERCESC-2138: -- What are the problems with a GitHub-based workflow specifically? Does GitBox proxy all this stuff to allow you to work without direct GitHub interaction? After switching over to git, it would be a great shame if we prevented more widespread community engagement with and access to the xerces codebase. Regarding 3.3, could we create a branch to allow new development in parallel with the stable 3.2 releases? While development would not necessarily be rapid or of great quantity, it would provide a place for development to take place without blocking it, or interfering with the stable branch. > Xerces-C++ should use C++98 features and remove pre-Standard workarounds > > > Key: XERCESC-2138 > URL: https://issues.apache.org/jira/browse/XERCESC-2138 > Project: Xerces-C++ > Issue Type: Bug > Components: Build >Affects Versions: 3.2.0 >Reporter: Johnny Willemsen >Assignee: Roger Leigh >Priority: Trivial > Attachments: 0001-Make-XSConstants-a-namespace.patch, > 0002-Drop-XERCES_HAS_CPP_NAMESPACE-check.patch, > 0003-Drop-XERCES_STD_NAMESPACE-check.patch, > 0004-Drop-XERCES_NO_NATIVE_BOOL-check.patch, > 0005-Drop-XERCES_NEW_IOSTREAMS-check.patch, > 0006-Use-cstdlib-in-place-of-stdlib.h.patch, > 0007-Use-cstdio-in-place-of-stdio.h.patch, > 0008-Use-cstring-in-place-of-string.h.patch, > 0009-Remove-use-of-strings.h.patch, > 0010-Use-std-in-place-of-XERCES_STD_QUALIFIER.patch, > 0011-Drop-const-workarounds.patch, 0012-Drop-inline-workarounds.patch, > 0013-Drop-unused-volatile-workarounds.patch, > 0014-Replace-XERCES_CPP_NAMESPACE-macros-with-real-namesp.patch > > > When compiling xercesc-3.2.0 with mingw-64 gcc 4.9.3 on Windows we get a lot > of warnings, for example: > class xercesc_3_2::XSConstants' only defines private constructors and has no > friends > In file included from > C:/cygwin64/home/administrator/build-ad87109bfff0765f4dd8cf4943b04d16a4070fea/xerces-c-3.2.0/src/xercesc/framework/psvi/XSObject.hpp:26:0, > Gandalf_win10_x86_64_01(administrator@172.16.2.213) > [pkg_xercesc:windows-pkg-xercesc] from > C:/cygwin64/home/administrator/build-ad87109bfff0765f4dd8cf4943b04d16a4070fea/xerces-c-3.2.0/src/xercesc/framework/psvi/XSTypeDefinition.hpp:25, > Gandalf_win10_x86_64_01(administrator@172.16.2.213) > [pkg_xercesc:windows-pkg-xercesc] from > C:/cygwin64/home/administrator/build-ad87109bfff0765f4dd8cf4943b04d16a4070fea/xerces-c-3.2.0/src/xercesc/framework/psvi/XSSimpleTypeDefinition.hpp:25, > Gandalf_win10_x86_64_01(administrator@172.16.2.213) > [pkg_xercesc:windows-pkg-xercesc] from > C:/cygwin64/home/administrator/build-ad87109bfff0765f4dd8cf4943b04d16a4070fea/xerces-c-3.2.0/src/xercesc/validators/datatype/DatatypeValidator.hpp:32, > Gandalf_win10_x86_64_01(administrator@172.16.2.213) > [pkg_xercesc:windows-pkg-xercesc] from > C:/cygwin64/home/administrator/build-ad87109bfff0765f4dd8cf4943b04d16a4070fea/xerces-c-3.2.0/src/xercesc/framework/XMLAttr.hpp:28, > Gandalf_win10_x86_64_01(administrator@172.16.2.213) > [pkg_xercesc:windows-pkg-xercesc] from > C:/cygwin64/home/administrator/build-ad87109bfff0765f4dd8cf4943b04d16a4070fea/xerces-c-3.2.0/src/xercesc/framework/XMLValidator.hpp:25, > Gandalf_win10_x86_64_01(administrator@172.16.2.213) > [pkg_xercesc:windows-pkg-xercesc] from > C:/cygwin64/home/administrator/build-ad87109bfff0765f4dd8cf4943b04d16a4070fea/xerces-c-3.2.0/src/xercesc/sax2/SAX2XMLReader.hpp:27, > Gandalf_win10_x86_64_01(administrator@172.16.2.213) > [pkg_xercesc:windows-pkg-xercesc] from > C:/cygwin64/home/administrator/build-ad87109bfff0765f4dd8cf4943b04d16a4070fea/xerces-c-3.2.0/samples/src/SAX2Print/SAX2Print.cpp:28: > Gandalf_win10_x86_64_01(administrator@172.16.2.213) > [pkg_xercesc:windows-pkg-xercesc] > C:/cygwin64/home/administrator/build-ad87109bfff0765f4dd8cf4943b04d16a4070fea/xerces-c-3.2.0/src/xercesc/framework/psvi/XSConstants.hpp:56:24: > warning: 'class xercesc_3_2::XSConstants' only defines private constructors > and has no friends [-Wctor-dtor-privacy] > Gandalf_win10_x86_64_01(administrator@172.16.2.213) > [pkg_xercesc:windows-pkg-xercesc] class XMLPARSER_EXPORT XSConstants > Gandalf_win10_x86_64_01(administrator@172.16.2.213) > [pkg_xercesc:windows-pkg-xercesc] ^ -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: c-dev-unsubscr...@xerces.apache.org For additional commands,
[jira] [Commented] (XERCESC-2156) fix static linking with curl
[ https://issues.apache.org/jira/browse/XERCESC-2156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17052450#comment-17052450 ] Roger Leigh commented on XERCESC-2156: -- The provided patch switches from the CMake FindCURL script to using pkg-config by default. I'm not sure that's the correct approach, but would be happy to discuss further. If FindCURL is not finding the static version of the CURL library, I think the best course of action would be to contribute the necessary fix for this module to CMake upstream and/or the CURL upstream if it's a CURL-provided config module. The patch as provided is using pkg-config by default and then falling back to FindCURL as a fallback. If we were to go with this approach, I think that we should be doing it the other way around and falling back to pkg-config, since FindCURL should be the canonical way to find it with CMake. > fix static linking with curl > > > Key: XERCESC-2156 > URL: https://issues.apache.org/jira/browse/XERCESC-2156 > Project: Xerces-C++ > Issue Type: Bug > Components: Build >Affects Versions: 3.2.0, 3.2.1, 3.2.2 >Reporter: Fabrice Fontaine >Assignee: Roger Leigh >Priority: Minor > Fix For: 3.2.3 > > Attachments: 0001-fix-static-linking-with-curl.patch > > > When curl is statically built with openssl support, xerces needs to > link with openssl libraries so use pkg_check_modules to get any > needed dependencies > Fixes: > - > http://autobuild.buildroot.org/results/29ca90fff2c8e38f2edf7240eca3aa3fe7397c45 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: c-dev-unsubscr...@xerces.apache.org For additional commands, e-mail: c-dev-h...@xerces.apache.org
Branching for 3.3 work?
There's an open bug or two that probably would need to lead to an API bump from 3.2 and the suggestion was made that even if we may not have a ton of active effort, there may be value in allowing such work to occur if the cycles to do it happen to be available. I don't have any problems personally with agreeing to apply the small number of changes that are likely to both branches in the interim, so I'm fine branching 3.2 off for maintenance and leaving master for other work if the rest of the PMC doesn't object. If anybody objects, let me know, otherwise I can branch it next week. -- Scott - To unsubscribe, e-mail: c-dev-unsubscr...@xerces.apache.org For additional commands, e-mail: c-dev-h...@xerces.apache.org
[jira] [Commented] (XERCESC-2138) Xerces-C++ should use C++98 features and remove pre-Standard workarounds
[ https://issues.apache.org/jira/browse/XERCESC-2138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17052461#comment-17052461 ] Scott Cantor commented on XERCESC-2138: --- I'm fine creating a branch if there's work desired to be done, I'll raise that with the PMC just as a sanity check and then look at branching 3.2 off and leaving master open. I do not expect sufficient work to happen that maintaining the branch would be a big problem. GitHub's terms of service require indemnifying them for IPR lawsuits, so that's untenable without indemnification insurance. I have worked on projects that IBM has sued before, so it is not a theoretical issue for me. I cannot commit code to GitHub and I made that clear when the proposal was made. I do some non-coding work there but never anything with risky IPR. If there were a way to accept the PR but have the commit made to gitbox, I would be fine with that. But a patch this size also probably needs a proper license or contribution agreement too. PRs may be easy to apply, but that doesn't make them "allowable", and that can be a problem too. But I haven't looked at the patch; if it's got a license attached that's fine. > Xerces-C++ should use C++98 features and remove pre-Standard workarounds > > > Key: XERCESC-2138 > URL: https://issues.apache.org/jira/browse/XERCESC-2138 > Project: Xerces-C++ > Issue Type: Bug > Components: Build >Affects Versions: 3.2.0 >Reporter: Johnny Willemsen >Assignee: Roger Leigh >Priority: Trivial > Attachments: 0001-Make-XSConstants-a-namespace.patch, > 0002-Drop-XERCES_HAS_CPP_NAMESPACE-check.patch, > 0003-Drop-XERCES_STD_NAMESPACE-check.patch, > 0004-Drop-XERCES_NO_NATIVE_BOOL-check.patch, > 0005-Drop-XERCES_NEW_IOSTREAMS-check.patch, > 0006-Use-cstdlib-in-place-of-stdlib.h.patch, > 0007-Use-cstdio-in-place-of-stdio.h.patch, > 0008-Use-cstring-in-place-of-string.h.patch, > 0009-Remove-use-of-strings.h.patch, > 0010-Use-std-in-place-of-XERCES_STD_QUALIFIER.patch, > 0011-Drop-const-workarounds.patch, 0012-Drop-inline-workarounds.patch, > 0013-Drop-unused-volatile-workarounds.patch, > 0014-Replace-XERCES_CPP_NAMESPACE-macros-with-real-namesp.patch > > > When compiling xercesc-3.2.0 with mingw-64 gcc 4.9.3 on Windows we get a lot > of warnings, for example: > class xercesc_3_2::XSConstants' only defines private constructors and has no > friends > In file included from > C:/cygwin64/home/administrator/build-ad87109bfff0765f4dd8cf4943b04d16a4070fea/xerces-c-3.2.0/src/xercesc/framework/psvi/XSObject.hpp:26:0, > Gandalf_win10_x86_64_01(administrator@172.16.2.213) > [pkg_xercesc:windows-pkg-xercesc] from > C:/cygwin64/home/administrator/build-ad87109bfff0765f4dd8cf4943b04d16a4070fea/xerces-c-3.2.0/src/xercesc/framework/psvi/XSTypeDefinition.hpp:25, > Gandalf_win10_x86_64_01(administrator@172.16.2.213) > [pkg_xercesc:windows-pkg-xercesc] from > C:/cygwin64/home/administrator/build-ad87109bfff0765f4dd8cf4943b04d16a4070fea/xerces-c-3.2.0/src/xercesc/framework/psvi/XSSimpleTypeDefinition.hpp:25, > Gandalf_win10_x86_64_01(administrator@172.16.2.213) > [pkg_xercesc:windows-pkg-xercesc] from > C:/cygwin64/home/administrator/build-ad87109bfff0765f4dd8cf4943b04d16a4070fea/xerces-c-3.2.0/src/xercesc/validators/datatype/DatatypeValidator.hpp:32, > Gandalf_win10_x86_64_01(administrator@172.16.2.213) > [pkg_xercesc:windows-pkg-xercesc] from > C:/cygwin64/home/administrator/build-ad87109bfff0765f4dd8cf4943b04d16a4070fea/xerces-c-3.2.0/src/xercesc/framework/XMLAttr.hpp:28, > Gandalf_win10_x86_64_01(administrator@172.16.2.213) > [pkg_xercesc:windows-pkg-xercesc] from > C:/cygwin64/home/administrator/build-ad87109bfff0765f4dd8cf4943b04d16a4070fea/xerces-c-3.2.0/src/xercesc/framework/XMLValidator.hpp:25, > Gandalf_win10_x86_64_01(administrator@172.16.2.213) > [pkg_xercesc:windows-pkg-xercesc] from > C:/cygwin64/home/administrator/build-ad87109bfff0765f4dd8cf4943b04d16a4070fea/xerces-c-3.2.0/src/xercesc/sax2/SAX2XMLReader.hpp:27, > Gandalf_win10_x86_64_01(administrator@172.16.2.213) > [pkg_xercesc:windows-pkg-xercesc] from > C:/cygwin64/home/administrator/build-ad87109bfff0765f4dd8cf4943b04d16a4070fea/xerces-c-3.2.0/samples/src/SAX2Print/SAX2Print.cpp:28: > Gandalf_win10_x86_64_01(administrator@172.16.2.213) > [pkg_xercesc:windows-pkg-xercesc] > C:/cygwin64/home/administrator/build-ad87109bfff0765f4dd8cf4943b04d16a4070fea/xerces-c-3.2.0/src/xercesc/framework/psvi/XSConstants.hpp:56:24: > warning: 'class xercesc_3_2::XSConstants' only defines private constructors > and has no friends [-Wctor-dtor-privacy] >
[jira] [Comment Edited] (XERCESC-2138) Xerces-C++ should use C++98 features and remove pre-Standard workarounds
[ https://issues.apache.org/jira/browse/XERCESC-2138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17052461#comment-17052461 ] Scott Cantor edited comment on XERCESC-2138 at 3/6/20, 2:52 AM: I'm fine creating a branch if there's work desired to be done, I'll raise that with the PMC just as a sanity check and then look at branching 3.2 off and leaving master open. I do not expect sufficient work to happen that maintaining the branch would be a big problem. GitHub's terms of service require indemnifying them for IPR lawsuits, so that's untenable without indemnification insurance. I have worked on projects that IBM has sued before, so it is not a theoretical issue for me. I cannot commit code to GitHub and I made that clear when the proposal was made. I do some non-coding work there but never anything with risky IPR. If there were a way to accept the PR but have the commit made to gitbox, I would be fine with that. (Edited to say, I didn't realize the patches came from Roger originally since the issue was filed by someone else, so I assume the contribution itself is fine.) was (Author: canto...@osu.edu): I'm fine creating a branch if there's work desired to be done, I'll raise that with the PMC just as a sanity check and then look at branching 3.2 off and leaving master open. I do not expect sufficient work to happen that maintaining the branch would be a big problem. GitHub's terms of service require indemnifying them for IPR lawsuits, so that's untenable without indemnification insurance. I have worked on projects that IBM has sued before, so it is not a theoretical issue for me. I cannot commit code to GitHub and I made that clear when the proposal was made. I do some non-coding work there but never anything with risky IPR. If there were a way to accept the PR but have the commit made to gitbox, I would be fine with that. But a patch this size also probably needs a proper license or contribution agreement too. PRs may be easy to apply, but that doesn't make them "allowable", and that can be a problem too. But I haven't looked at the patch; if it's got a license attached that's fine. > Xerces-C++ should use C++98 features and remove pre-Standard workarounds > > > Key: XERCESC-2138 > URL: https://issues.apache.org/jira/browse/XERCESC-2138 > Project: Xerces-C++ > Issue Type: Bug > Components: Build >Affects Versions: 3.2.0 >Reporter: Johnny Willemsen >Assignee: Roger Leigh >Priority: Trivial > Attachments: 0001-Make-XSConstants-a-namespace.patch, > 0002-Drop-XERCES_HAS_CPP_NAMESPACE-check.patch, > 0003-Drop-XERCES_STD_NAMESPACE-check.patch, > 0004-Drop-XERCES_NO_NATIVE_BOOL-check.patch, > 0005-Drop-XERCES_NEW_IOSTREAMS-check.patch, > 0006-Use-cstdlib-in-place-of-stdlib.h.patch, > 0007-Use-cstdio-in-place-of-stdio.h.patch, > 0008-Use-cstring-in-place-of-string.h.patch, > 0009-Remove-use-of-strings.h.patch, > 0010-Use-std-in-place-of-XERCES_STD_QUALIFIER.patch, > 0011-Drop-const-workarounds.patch, 0012-Drop-inline-workarounds.patch, > 0013-Drop-unused-volatile-workarounds.patch, > 0014-Replace-XERCES_CPP_NAMESPACE-macros-with-real-namesp.patch > > > When compiling xercesc-3.2.0 with mingw-64 gcc 4.9.3 on Windows we get a lot > of warnings, for example: > class xercesc_3_2::XSConstants' only defines private constructors and has no > friends > In file included from > C:/cygwin64/home/administrator/build-ad87109bfff0765f4dd8cf4943b04d16a4070fea/xerces-c-3.2.0/src/xercesc/framework/psvi/XSObject.hpp:26:0, > Gandalf_win10_x86_64_01(administrator@172.16.2.213) > [pkg_xercesc:windows-pkg-xercesc] from > C:/cygwin64/home/administrator/build-ad87109bfff0765f4dd8cf4943b04d16a4070fea/xerces-c-3.2.0/src/xercesc/framework/psvi/XSTypeDefinition.hpp:25, > Gandalf_win10_x86_64_01(administrator@172.16.2.213) > [pkg_xercesc:windows-pkg-xercesc] from > C:/cygwin64/home/administrator/build-ad87109bfff0765f4dd8cf4943b04d16a4070fea/xerces-c-3.2.0/src/xercesc/framework/psvi/XSSimpleTypeDefinition.hpp:25, > Gandalf_win10_x86_64_01(administrator@172.16.2.213) > [pkg_xercesc:windows-pkg-xercesc] from > C:/cygwin64/home/administrator/build-ad87109bfff0765f4dd8cf4943b04d16a4070fea/xerces-c-3.2.0/src/xercesc/validators/datatype/DatatypeValidator.hpp:32, > Gandalf_win10_x86_64_01(administrator@172.16.2.213) > [pkg_xercesc:windows-pkg-xercesc] from > C:/cygwin64/home/administrator/build-ad87109bfff0765f4dd8cf4943b04d16a4070fea/xerces-c-3.2.0/src/xercesc/framework/XMLAttr.hpp:28, > Gandalf_win10_x86_64_01(administrator@172.16.2.213) > [pkg_xercesc:windows-pkg-xercesc] from >
Re: Branching for 3.3 work?
Cantor, Scott writes: > There's an open bug or two that probably would need to lead to an API bump > from 3.2 and the suggestion was made that even if we may not have a ton of > active effort, there may be value in allowing such work to occur if the > cycles to do it happen to be available. > > I don't have any problems personally with agreeing to apply the small number > of changes that are likely to both branches in the interim, so I'm fine > branching 3.2 off for maintenance and leaving master for other work if the > rest of the PMC doesn't object. Just to confirm my understanding, you would like to create the 3.2-series branch in order to release 3.2.3 with some cherry-picked commits, correct? If so, I am wondering why not instead go ahead and release master as 3.3? - To unsubscribe, e-mail: c-dev-unsubscr...@xerces.apache.org For additional commands, e-mail: c-dev-h...@xerces.apache.org
[jira] [Commented] (XERCESC-2163) XercesMessages_en_US.cat is installed to wrong directory
[ https://issues.apache.org/jira/browse/XERCESC-2163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17052554#comment-17052554 ] Craig commented on XERCESC-2163: I've opened a new PR: [https://github.com/apache/xerces-c/pull/7] Thank you for point this out! > XercesMessages_en_US.cat is installed to wrong directory > > > Key: XERCESC-2163 > URL: https://issues.apache.org/jira/browse/XERCESC-2163 > Project: Xerces-C++ > Issue Type: Bug > Components: Build >Affects Versions: 3.2.0, 3.2.1, 3.2.2 >Reporter: Craig >Assignee: Roger Leigh >Priority: Major > Labels: cmake > Fix For: 3.2.3 > > > When building with the > {code}-Dmessage-loader=iconv{code} > cmake option, {{XercesMessages_en_US.cat}} is installed to: > {{/usr/msg/}} > It should be installed to: > {{/usr/share/xerces-c/msg/}} > which is what previous versions of Xerces-C did. > This change breaks downstream consumers of Xerces-C, such as Xalan-C (which > fails to build as it cannot find {{XercesMessages_en_US.cat}}). > Originally reported at https://bugs.gentoo.org/673548 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: c-dev-unsubscr...@xerces.apache.org For additional commands, e-mail: c-dev-h...@xerces.apache.org
[GitHub] [xerces-c] candrews opened a new pull request #7: build: Install XercesMessages_en_US.cat to /usr/share/xerces-c/msg
candrews opened a new pull request #7: build: Install XercesMessages_en_US.cat to /usr/share/xerces-c/msg URL: https://github.com/apache/xerces-c/pull/7 Fixes XERCESC-2163 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: c-dev-unsubscr...@xerces.apache.org For additional commands, e-mail: c-dev-h...@xerces.apache.org
[jira] [Commented] (XERCESC-2156) fix static linking with curl
[ https://issues.apache.org/jira/browse/XERCESC-2156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17052551#comment-17052551 ] Fabrice Fontaine commented on XERCESC-2156: --- >From my experience, cmake does not really support or care about static >linking. FindCURL.cmake (which is provided by upstream cmake: >[https://github.com/Kitware/CMake/blob/master/Modules/FindCURL.cmake)] already >uses pkg-config but instead of retrieving the libraries from it (-lcurl but >also -lssl, -lcrypto, -lz, -latomic ...), it just uses PC_CURL_LIBRARY_DIRS as >an hint to find and save -lcurl library in CURL_LIBRAR\{Y,IES}. Moreover, even if we could convince upstream to update FindCURL.cmake, it will only be fixed in an upcoming release and so users using old cmake will still have build failures when linking statically with curl. So, at the end, from my perspective, there is two options: * This patch is merged and pkg-config is used instead of FindCURL (we can't use FindCURL and fallback to pkg-config because FindCURL doesn't return any error) * This patch is not acceptable from your point of view. In this case, I'll also remove this patch from buildroot and I'll instead add a dynamic library dependency to xerces. Buildroot users won't be able to build xerces statically anymore but I prefer this instead of maintaining non-upstreamable patches. > fix static linking with curl > > > Key: XERCESC-2156 > URL: https://issues.apache.org/jira/browse/XERCESC-2156 > Project: Xerces-C++ > Issue Type: Bug > Components: Build >Affects Versions: 3.2.0, 3.2.1, 3.2.2 >Reporter: Fabrice Fontaine >Assignee: Roger Leigh >Priority: Minor > Fix For: 3.2.3 > > Attachments: 0001-fix-static-linking-with-curl.patch > > > When curl is statically built with openssl support, xerces needs to > link with openssl libraries so use pkg_check_modules to get any > needed dependencies > Fixes: > - > http://autobuild.buildroot.org/results/29ca90fff2c8e38f2edf7240eca3aa3fe7397c45 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: c-dev-unsubscr...@xerces.apache.org For additional commands, e-mail: c-dev-h...@xerces.apache.org
[jira] [Comment Edited] (XERCESC-2194) Including Xerces_autoconf_config.hpp on Windows fails due to undefined ssize_t
[ https://issues.apache.org/jira/browse/XERCESC-2194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17052212#comment-17052212 ] Rasmus Thomsen edited comment on XERCESC-2194 at 3/5/20, 2:58 PM: -- According to [the CMake docs|https://cmake.org/cmake/help/v3.17/module/CheckTypeSize.html?highlight=i] it might be a better idea to use {code}HAVE_${TYPE}{code} in XercesIntTypes.cmake instead of SIZEOF_SSIZE_T to determine if it's available: {code} -if(SIZEOF_SIZE_T) +if(HAVE_SIZEOF_SIZE_T) set(XERCES_SIZE_T size_t) set(XERCES_SIZE_MAX SIZE_MAX) else() set(XERCES_SIZE_T "unsigned long") set(XERCES_SIZE_MAX ULONG_MAX) endif() -if(SIZEOF_SSIZE_T) +if(HAVE_SIZEOF_SSIZE_T) set(XERCES_SSIZE_T SIZEOF_SSIZE_T) set(XERCES_SSIZE_MAX SSIZE_MAX) else() set(XERCES_SSIZE_T long) set(XERCES_SSIZE_MAX LONG_MAX) endif() {code} Or something along those lines? was (Author: cogitri): According to [the CMake docs|https://cmake.org/cmake/help/v3.17/module/CheckTypeSize.html?highlight=i] it might be a better idea to use {code}HAVE_${TYPE}{code} in XercesIntTypes.cmake instead of SIZEOF_SSIZE_T to determine if it's available: {code} -if(SIZEOF_SIZE_T) +if(HAVE_SIZEOF_OFF_T) set(XERCES_SIZE_T size_t) set(XERCES_SIZE_MAX SIZE_MAX) else() set(XERCES_SIZE_T "unsigned long") set(XERCES_SIZE_MAX ULONG_MAX) endif() -if(SIZEOF_SSIZE_T) +if(HAVE_ssize_t) set(XERCES_SSIZE_T SIZEOF_SSIZE_T) set(XERCES_SSIZE_MAX SSIZE_MAX) else() set(XERCES_SSIZE_T long) set(XERCES_SSIZE_MAX LONG_MAX) endif() {code} Or something along those lines? > Including Xerces_autoconf_config.hpp on Windows fails due to undefined ssize_t > -- > > Key: XERCESC-2194 > URL: https://issues.apache.org/jira/browse/XERCESC-2194 > Project: Xerces-C++ > Issue Type: Bug > Components: Build >Affects Versions: 3.2.2 >Reporter: Rasmus Thomsen >Priority: Major > > When including Xerces_autoconf_config.hpp on Windows the following error > messages: > > {code:cpp} > error C4430: Fehlender Typspezifizierer - int wird angenommen. Hinweis: > "default-int" wird von C++ nicht unterstützt. > error C2146: Syntaxfehler: Fehlendes ";" vor Bezeichner "XMLSSize_t" > {code} > (Sorry that these are in German - they translate to "Missing type specifier - > assuming int" and "syntax error: missing ";" before identifier "XMLSSize_t") > Apparently ssize_t is a POSIX extension and as such isn't available in MSVC > (by default?) -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: c-dev-unsubscr...@xerces.apache.org For additional commands, e-mail: c-dev-h...@xerces.apache.org
[jira] [Comment Edited] (XERCESC-2194) Including Xerces_autoconf_config.hpp on Windows fails due to undefined ssize_t
[ https://issues.apache.org/jira/browse/XERCESC-2194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17052212#comment-17052212 ] Rasmus Thomsen edited comment on XERCESC-2194 at 3/5/20, 2:58 PM: -- According to [the CMake docs|https://cmake.org/cmake/help/v3.17/module/CheckTypeSize.html?highlight=i] it might be a better idea to use {code}HAVE_${TYPE}{code} in XercesIntTypes.cmake instead of SIZEOF_SSIZE_T to determine if it's available: {code} -if(SIZEOF_SIZE_T) +if(HAVE_SIZEOF_OFF_T) set(XERCES_SIZE_T size_t) set(XERCES_SIZE_MAX SIZE_MAX) else() set(XERCES_SIZE_T "unsigned long") set(XERCES_SIZE_MAX ULONG_MAX) endif() -if(SIZEOF_SSIZE_T) +if(HAVE_ssize_t) set(XERCES_SSIZE_T SIZEOF_SSIZE_T) set(XERCES_SSIZE_MAX SSIZE_MAX) else() set(XERCES_SSIZE_T long) set(XERCES_SSIZE_MAX LONG_MAX) endif() {code} Or something along those lines? was (Author: cogitri): According to [the CMake docs|https://cmake.org/cmake/help/v3.17/module/CheckTypeSize.html?highlight=i] it might be a better idea to use {code}HAVE_${TYPE}{code} in XercesIntTypes.cmake instead of SIZEOF_SSIZE_T to determine if it's available: {code:diff} -if(SIZEOF_SIZE_T) +if(HAVE_SIZEOF_OFF_T) set(XERCES_SIZE_T size_t) set(XERCES_SIZE_MAX SIZE_MAX) else() set(XERCES_SIZE_T "unsigned long") set(XERCES_SIZE_MAX ULONG_MAX) endif() -if(SIZEOF_SSIZE_T) +if(HAVE_ssize_t) set(XERCES_SSIZE_T SIZEOF_SSIZE_T) set(XERCES_SSIZE_MAX SSIZE_MAX) else() set(XERCES_SSIZE_T long) set(XERCES_SSIZE_MAX LONG_MAX) endif() {code} Or something along those lines? > Including Xerces_autoconf_config.hpp on Windows fails due to undefined ssize_t > -- > > Key: XERCESC-2194 > URL: https://issues.apache.org/jira/browse/XERCESC-2194 > Project: Xerces-C++ > Issue Type: Bug > Components: Build >Affects Versions: 3.2.2 >Reporter: Rasmus Thomsen >Priority: Major > > When including Xerces_autoconf_config.hpp on Windows the following error > messages: > > {code:cpp} > error C4430: Fehlender Typspezifizierer - int wird angenommen. Hinweis: > "default-int" wird von C++ nicht unterstützt. > error C2146: Syntaxfehler: Fehlendes ";" vor Bezeichner "XMLSSize_t" > {code} > (Sorry that these are in German - they translate to "Missing type specifier - > assuming int" and "syntax error: missing ";" before identifier "XMLSSize_t") > Apparently ssize_t is a POSIX extension and as such isn't available in MSVC > (by default?) -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: c-dev-unsubscr...@xerces.apache.org For additional commands, e-mail: c-dev-h...@xerces.apache.org
[jira] [Commented] (XERCESC-2194) Including Xerces_autoconf_config.hpp on Windows fails due to undefined ssize_t
[ https://issues.apache.org/jira/browse/XERCESC-2194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17052212#comment-17052212 ] Rasmus Thomsen commented on XERCESC-2194: - According to [the CMake docs|https://cmake.org/cmake/help/v3.17/module/CheckTypeSize.html?highlight=i] it might be a better idea to use {code}HAVE_${TYPE}{code} in XercesIntTypes.cmake instead of SIZEOF_SSIZE_T to determine if it's available: {code:diff} -if(SIZEOF_SIZE_T) +if(HAVE_SIZEOF_OFF_T) set(XERCES_SIZE_T size_t) set(XERCES_SIZE_MAX SIZE_MAX) else() set(XERCES_SIZE_T "unsigned long") set(XERCES_SIZE_MAX ULONG_MAX) endif() -if(SIZEOF_SSIZE_T) +if(HAVE_ssize_t) set(XERCES_SSIZE_T SIZEOF_SSIZE_T) set(XERCES_SSIZE_MAX SSIZE_MAX) else() set(XERCES_SSIZE_T long) set(XERCES_SSIZE_MAX LONG_MAX) endif() {code} Or something along those lines? > Including Xerces_autoconf_config.hpp on Windows fails due to undefined ssize_t > -- > > Key: XERCESC-2194 > URL: https://issues.apache.org/jira/browse/XERCESC-2194 > Project: Xerces-C++ > Issue Type: Bug > Components: Build >Affects Versions: 3.2.2 >Reporter: Rasmus Thomsen >Priority: Major > > When including Xerces_autoconf_config.hpp on Windows the following error > messages: > > {code:cpp} > error C4430: Fehlender Typspezifizierer - int wird angenommen. Hinweis: > "default-int" wird von C++ nicht unterstützt. > error C2146: Syntaxfehler: Fehlendes ";" vor Bezeichner "XMLSSize_t" > {code} > (Sorry that these are in German - they translate to "Missing type specifier - > assuming int" and "syntax error: missing ";" before identifier "XMLSSize_t") > Apparently ssize_t is a POSIX extension and as such isn't available in MSVC > (by default?) -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: c-dev-unsubscr...@xerces.apache.org For additional commands, e-mail: c-dev-h...@xerces.apache.org
[jira] [Comment Edited] (XERCESC-2194) Including Xerces_autoconf_config.hpp on Windows fails due to undefined ssize_t
[ https://issues.apache.org/jira/browse/XERCESC-2194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17052206#comment-17052206 ] Rasmus Thomsen edited comment on XERCESC-2194 at 3/5/20, 2:52 PM: -- Hm, CMake does check for ssize_t and recognizes that it's not available: {code}-- Check size of ssize_t - failed{code} but we still end up with ssize_t in the mentioned header in our builds. We're building from the 3.2.2 Git tag. We use MSVC version 19.14.26428.1 was (Author: cogitri): Hm, CMake does check for ssize_t and recognizes that it's not available: {code}-- Check size of ssize_t - failed{code} but we still end up with ssize_t in our builds. We're building from the 3.2.2 Git tag. We use MSVC version 19.14.26428.1 > Including Xerces_autoconf_config.hpp on Windows fails due to undefined ssize_t > -- > > Key: XERCESC-2194 > URL: https://issues.apache.org/jira/browse/XERCESC-2194 > Project: Xerces-C++ > Issue Type: Bug > Components: Build >Affects Versions: 3.2.2 >Reporter: Rasmus Thomsen >Priority: Major > > When including Xerces_autoconf_config.hpp on Windows the following error > messages: > > {code:cpp} > error C4430: Fehlender Typspezifizierer - int wird angenommen. Hinweis: > "default-int" wird von C++ nicht unterstützt. > error C2146: Syntaxfehler: Fehlendes ";" vor Bezeichner "XMLSSize_t" > {code} > (Sorry that these are in German - they translate to "Missing type specifier - > assuming int" and "syntax error: missing ";" before identifier "XMLSSize_t") > Apparently ssize_t is a POSIX extension and as such isn't available in MSVC > (by default?) -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: c-dev-unsubscr...@xerces.apache.org For additional commands, e-mail: c-dev-h...@xerces.apache.org
[jira] [Commented] (XERCESC-2194) Including Xerces_autoconf_config.hpp on Windows fails due to undefined ssize_t
[ https://issues.apache.org/jira/browse/XERCESC-2194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17052206#comment-17052206 ] Rasmus Thomsen commented on XERCESC-2194: - Hm, CMake does check for ssize_t and recognizes that it's not available: {code}-- Check size of ssize_t - failed{code} but we still end up with ssize_t in our builds. We're building from the 3.2.2 Git tag. We use MSVC version 19.14.26428.1 > Including Xerces_autoconf_config.hpp on Windows fails due to undefined ssize_t > -- > > Key: XERCESC-2194 > URL: https://issues.apache.org/jira/browse/XERCESC-2194 > Project: Xerces-C++ > Issue Type: Bug > Components: Build >Affects Versions: 3.2.2 >Reporter: Rasmus Thomsen >Priority: Major > > When including Xerces_autoconf_config.hpp on Windows the following error > messages: > > {code:cpp} > error C4430: Fehlender Typspezifizierer - int wird angenommen. Hinweis: > "default-int" wird von C++ nicht unterstützt. > error C2146: Syntaxfehler: Fehlendes ";" vor Bezeichner "XMLSSize_t" > {code} > (Sorry that these are in German - they translate to "Missing type specifier - > assuming int" and "syntax error: missing ";" before identifier "XMLSSize_t") > Apparently ssize_t is a POSIX extension and as such isn't available in MSVC > (by default?) -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: c-dev-unsubscr...@xerces.apache.org For additional commands, e-mail: c-dev-h...@xerces.apache.org